Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disabled get_batch consensus RPC #2511

Merged
merged 2 commits into from
Jul 29, 2024
Merged

chore: disabled get_batch consensus RPC #2511

merged 2 commits into from
Jul 29, 2024

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented Jul 26, 2024

get_batch is not fully implemented yet (neither in era-consensus nor zksync-era) but it already is consuming resources (db queries and bandwidth). We should finish implementation and loadtest it before enabling it again.

@pompon0 pompon0 requested a review from aakoshh July 26, 2024 13:28
@pompon0 pompon0 enabled auto-merge July 26, 2024 13:28
Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, if the traffic it generates is unrealistic. I thought it might be indicative of the volume of data it would download, maybe worth having a look at the metrics even if we can't actually evaluate the proof and all we do is discard the batches.

Just to give some extra context, IIUC the batches are pulled because run_batch_fetcher gets them, always trying to download one more than what it already has in its queued cache. However I was never able to ascertain how things make their way into the queued at the moment, which could be because this hasn't been developed yet.

Did this actually generate traffic already?

@pompon0
Copy link
Contributor Author

pompon0 commented Jul 26, 2024

yes, you can see that get_batch RPC takes up to 3s https://grafana.matterlabs.dev/d/eba66cd9-5335-4521-9777-ad34a379f35c/era-consensus?orgId=1&var-datasource=mIPIusa4k . I haven't analyzed the exact impact on the db resources, but I'd like to understand it before we enable it on testnet or mainnet.

@pompon0 pompon0 added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@pompon0 pompon0 added this pull request to the merge queue Jul 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 29, 2024
@pompon0 pompon0 added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit a12699a Jul 29, 2024
47 checks passed
@pompon0 pompon0 deleted the gprusak-disable-batch branch July 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants