feat: add general config and secrets opts to snapshot creator #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
reviewed
Jul 24, 2024
Deniallugo
previously approved these changes
Jul 24, 2024
Deniallugo
previously approved these changes
Jul 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Deniallugo
approved these changes
Jul 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
🤖 I have created a release *beep* *boop* --- ## [24.12.0](core-v24.11.0...core-v24.12.0) (2024-07-25) ### Features * add general config and secrets opts to snapshot creator ([#2471](#2471)) ([0f475c9](0f475c9)) * Update to consensus 0.1.0-rc.4 (BFT-486) ([#2475](#2475)) ([ff6b10c](ff6b10c)) ### Bug Fixes * consensus secrets generator ([#2484](#2484)) ([dea6969](dea6969)) ### Performance Improvements * writing tx to bootloader memory is no longer quadratic ([#2479](#2479)) ([1c443e5](1c443e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: Roman Brodetski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds
--config-pathand--secrets-pathoptions to/core/bin/snapshots_creator. Allowing the binary to source configurations from files.Why ❔
Needed in order to run the command within
zk_toolbox.Checklist
zk fmtandzk lint.