-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(prover_cli): Fix delete command #2119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. We also need to delete the delete_gpu_prover_queue_fri_archive
method from FriGpuProverQueueDal
…s/zksync-era into prover_cli_fix_delete_command
…s/zksync-era into prover_cli_fix_delete_command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are some things failing in the CI
Changes: - Get database url from the `prover_cli` config. - Remove the deletion of archived jobs. --------- Co-authored-by: Ivan Litteri <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [15.0.0](prover-v14.5.0...prover-v15.0.0) (2024-06-14) ### ⚠ BREAKING CHANGES * updated boojum and nightly rust compiler ([#2126](#2126)) ### Features * added debug_proof to prover_cli ([#2052](#2052)) ([b1ad01b](b1ad01b)) * faster & cleaner VK generation ([#2084](#2084)) ([89c8cac](89c8cac)) * **node:** Move some stuff around ([#2151](#2151)) ([bad5a6c](bad5a6c)) * **object-store:** Allow caching object store objects locally ([#2153](#2153)) ([6c6e65c](6c6e65c)) * **proof_data_handler:** add new endpoints to the TEE prover interface API ([#1993](#1993)) ([eca98cc](eca98cc)) * **prover:** Add file based config for fri prover gateway ([#2150](#2150)) ([81ffc6a](81ffc6a)) * **prover:** file based configs for witness generator ([#2161](#2161)) ([24b8f93](24b8f93)) * support debugging of recursive circuits in prover_cli ([#2217](#2217)) ([7d2e12d](7d2e12d)) * updated boojum and nightly rust compiler ([#2126](#2126)) ([9e39f13](9e39f13)) * verification of L1Batch witness (BFT-471) - attempt 2 ([#2232](#2232)) ([dbcf3c6](dbcf3c6)) * verification of L1Batch witness (BFT-471) ([#2019](#2019)) ([6cc5455](6cc5455)) ### Bug Fixes * **config:** Split object stores ([#2187](#2187)) ([9bcdabc](9bcdabc)) * **prover_cli:** Fix delete command ([#2119](#2119)) ([214f981](214f981)) * **prover_cli:** Fix the issues with `home` path ([#2104](#2104)) ([1e18af2](1e18af2)) * **prover:** config ([#2165](#2165)) ([e5daf8e](e5daf8e)) * **prover:** Disallow state changes from successful ([#2233](#2233)) ([2488a76](2488a76)) * Treat 502s and 503s as transient for GCS OS ([#2202](#2202)) ([0a12c52](0a12c52)) ### Reverts * verification of L1Batch witness (BFT-471) ([#2230](#2230)) ([227e101](227e101)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Changes:
prover_cli
config.