Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(state-keeper): Propagate errors in batch executor #2090

Merged
merged 1 commit into from
May 30, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented May 29, 2024

What ❔

Propagates errors in the batch executor instead of panicking.

Why ❔

Batch executor somewhat frequently panics on node shutdown. This is suboptimal UX, can lead to false positive bug reports etc.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@slowli slowli marked this pull request as ready for review May 30, 2024 07:33
@slowli slowli requested review from itegulov, popzxc and perekopskiy May 30, 2024 07:33
@slowli slowli added this pull request to the merge queue May 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 30, 2024
@slowli slowli added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit b3248e4 May 30, 2024
48 checks passed
@slowli slowli deleted the aov-pla-955-propagate-errors-in-batch-executor branch May 30, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants