fix(en): Minor node fixes #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
commented
May 17, 2024
popzxc
approved these changes
May 17, 2024
aon
pushed a commit
that referenced
this pull request
May 17, 2024
## What ❔ Fixes minor issues with the EN: - Transient error detection for RPC clients is suboptimal, leading to what really is a transient error crashing consistency checker. - Since refactoring signal handling, `ManagedTasks::wait_single()` on EN may inappropriately log task termination errors even after a signal is being received. - Since recent refactoring (?), block fetcher doesn't tag its L2 client. - Block fetcher may produce many rate limiting logs, which currently have WARN level. - Initializing L2 client multiple times (e.g., in a load test) produces many WARN logs. ## Why ❔ Improves EN UX. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- ## [24.4.0](core-v24.3.0...core-v24.4.0) (2024-05-21) ### Features * **prover:** add GPU feature for compressor ([#1838](#1838)) ([e9a2213](e9a2213)) * **pruning:** remove manual vaccum; add migration configuring autovacuum ([#1983](#1983)) ([3d98072](3d98072)) * **tests:** Move all env calls to one place in ts-tests ([#1968](#1968)) ([3300047](3300047)) ### Bug Fixes * Disallow non null updates for transactions ([#1951](#1951)) ([a603ac8](a603ac8)) * **en:** Minor node fixes ([#1978](#1978)) ([74144e8](74144e8)) * **en:** run `MainNodeFeeParamsFetcher` in API component ([#1988](#1988)) ([b62677e](b62677e)) * **merkle-tree:** Fix tree API health check status ([#1973](#1973)) ([6235561](6235561)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Fixes minor issues with the EN:
ManagedTasks::wait_single()on EN may inappropriately log task termination errors even after a signal is being received.Why ❔
Improves EN UX.
Checklist
zk fmtandzk lint.zk spellcheck.