Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update protocol upgrade tool for stm EVM-598 #1834

Merged
merged 13 commits into from
May 31, 2024
Merged

feat: update protocol upgrade tool for stm EVM-598 #1834

merged 13 commits into from
May 31, 2024

Conversation

kelemeno
Copy link
Contributor

@kelemeno kelemeno commented Apr 30, 2024 •
edited
Loading

Warning: bumps contracts for STM contract, do not merge until contracts are merged.

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@kelemeno kelemeno changed the title feat: update protocol upgrade tool for stm feat: update protocol upgrade tool for stm EVM-598 May 6, 2024
@kelemeno kelemeno marked this pull request as ready for review May 29, 2024 08:56
@github-actions GitHub Actions
Copy link
Contributor

No performance difference detected (anymore)

StanislavBreadless
StanislavBreadless approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in private with @kelemeno, the PR was approved

@StanislavBreadless StanislavBreadless added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 1c5229c May 31, 2024
19 checks passed
@StanislavBreadless StanislavBreadless deleted the kl/update-protocol-upgrade-tool-for-stm branch May 31, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelemeno @StanislavBreadless