Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Prover CLI): status command lwg #1830

Merged
merged 12 commits into from
Apr 30, 2024
Merged

feat(Prover CLI): status command lwg #1830

merged 12 commits into from
Apr 30, 2024

Conversation

ColoCarletti
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@ColoCarletti ColoCarletti requested a review from ilitteri April 29, 2024 17:28
ilitteri
ilitteri reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments and nits. We can merge after testing and solving the Leaf and Node WG structs.

core/lib/basic_types/src/prover_dal.rs Show resolved Hide resolved
core/lib/basic_types/src/prover_dal.rs Show resolved Hide resolved
prover/prover_dal/src/fri_witness_generator_dal.rs Outdated Show resolved Hide resolved
ilitteri
ilitteri approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilitteri ilitteri changed the title Prover cli status command lwg feat(Prover CLI): status command lwg Apr 30, 2024
@ColoCarletti ColoCarletti merged commit dbaf3b4 into prover_cli_status_command Apr 30, 2024
30 of 38 checks passed
@ColoCarletti ColoCarletti deleted the prover_cli_status_command_lwg branch April 30, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilitteri ilitteri ilitteri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColoCarletti @ilitteri