Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snapshots_creator): Remove snapshots during reverts #1757

Merged
merged 18 commits into from
Apr 26, 2024
Merged

fix(snapshots_creator): Remove snapshots during reverts #1757

merged 18 commits into from
Apr 26, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Apr 22, 2024 •
edited
Loading

What ❔

  • Reverts snapshot metadata and GCS data for snapshots removed during reverts.
  • Brushes up the reverter crate.

Why ❔

  • If the snapshots are not removed, they'll contain bogus data.
  • Removing snapshot objects from GCS is not strictly necessary, but simplifies handling corner cases (e.g., creating a later snapshot with the same L1 batch number; removing a snapshot in the middle of EN recovery).

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@slowli slowli marked this pull request as ready for review April 22, 2024 14:42
@slowli slowli force-pushed the aov-pla-884-remove-snapshots-during-reverts branch from 246c98f to 1e7f750 Compare April 24, 2024 09:17
slowli
slowli commented Apr 24, 2024
View reviewed changes
core/bin/block_reverter/src/main.rs Outdated Show resolved Hide resolved
core/bin/block_reverter/src/main.rs Show resolved Hide resolved
@slowli slowli requested a review from montekki April 25, 2024 10:17
montekki
montekki previously approved these changes Apr 26, 2024
View reviewed changes
RomanBrodetski
RomanBrodetski previously approved these changes Apr 26, 2024
View reviewed changes
@slowli slowli dismissed stale reviews from RomanBrodetski and montekki via 5fd06d8 April 26, 2024 11:32
@montekki montekki enabled auto-merge April 26, 2024 13:00
@montekki montekki added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 8d587fd Apr 26, 2024
36 checks passed
@montekki montekki deleted the aov-pla-884-remove-snapshots-during-reverts branch April 26, 2024 13:53
@zksync-era-bot zksync-era-bot mentioned this pull request Apr 26, 2024
Merged
RomanBrodetski pushed a commit that referenced this pull request Apr 30, 2024
@zksync-era-bot @perekopskiy
chore(main): release core 24.0.0 (#1758)
e9d41a6 
🤖 I have created a release *beep* *boop*
---


##
[24.0.0](core-v23.1.0...core-v24.0.0)
(2024-04-30)


### ⚠ BREAKING CHANGES

* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
* shared bridge
([#298](#298))

### Features

* **api:** Allow granular max response size config
([#1642](#1642))
([83c4034](83c4034))
* **api:** Improve logging for API server
([#1792](#1792))
([50fbda5](50fbda5))
* **api:** Track params for RPC methods
([#1673](#1673))
([1a34c8b](1a34c8b))
* **configs:** move ecosystem contracts to contracts
([#1606](#1606))
([9d52180](9d52180))
* EcPairing precompile as system contract
([#1761](#1761))
([3071622](3071622))
* Include create2 factory in genesis
([#1775](#1775))
([597280b](597280b))
* **prover:** Protocol Upgrade 1.5.0
([#1699](#1699))
([6a557f7](6a557f7))
* **prover:** remove redundant config fields
([#1787](#1787))
([a784ea6](a784ea6))
* shared bridge
([#298](#298))
([8c3478a](8c3478a))
* **tree:** Improved tree pruning
([#1532](#1532))
([bcb192c](bcb192c))
* **vm-runner:** implement VM runner storage layer
([#1651](#1651))
([543f9e9](543f9e9))
* **vm:** Extend bootloader memory in the new version
([#1807](#1807))
([f461b28](f461b28))


### Bug Fixes

* **api:** Fix extra DB connection acquisition during tx submission
([#1793](#1793))
([9c6ed83](9c6ed83))
* **en:** correct en config vars
([#1809](#1809))
([d340fbc](d340fbc))
* **en:** Remove duplicate reorg detector
([#1783](#1783))
([3417941](3417941))
* **kl-factory:** base token ether tests
([#1746](#1746))
([6cf14a0](6cf14a0))
* **prover:** Fix panics if prover's config is not ready
([#1822](#1822))
([21d90d7](21d90d7))
* **snapshots_creator:** Remove snapshots during reverts
([#1757](#1757))
([8d587fd](8d587fd))
* **types:** Add LegacyMixedCall
([#1773](#1773))
([2b236fe](2b236fe))
* v23 api typo
([#1821](#1821))
([a11fa86](a11fa86))
* Weaker assert for protocol version for operations
([#1800](#1800))
([11898c2](11898c2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: perekopskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montekki montekki montekki approved these changes

@AnastasiiaVashchuk AnastasiiaVashchuk AnastasiiaVashchuk left review comments

@RomanBrodetski RomanBrodetski RomanBrodetski left review comments

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slowli @montekki @RomanBrodetski @AnastasiiaVashchuk