Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Uses PAT token for release please #165

Merged
merged 1 commit into from
Oct 5, 2023
Merged

ci: Uses PAT token for release please #165

merged 1 commit into from
Oct 5, 2023

Conversation

yorik
Copy link
Contributor

@yorik yorik commented Oct 5, 2023

What ❔

Uses PAT token for release please.

Why ❔

To allow other workflows to be triggered by tags creation.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@yorik yorik requested a review from a team as a code owner October 5, 2023 16:45
@yorik yorik enabled auto-merge October 5, 2023 16:56
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0d952d4) 31.59% compared to head (c8f3c93) 31.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   31.59%   31.52%   -0.07%     
==========================================
  Files         478      478              
  Lines       25463    25463              
==========================================
- Hits         8044     8027      -17     
- Misses      17419    17436      +17     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yorik yorik added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 5531be3 Oct 5, 2023
31 checks passed
hatemosphere pushed a commit that referenced this pull request Oct 6, 2023
# What ❔

Uses PAT token for release please.

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

To allow other workflows to be triggered by tags creation.
<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
Oppen referenced this pull request in lambdaclass/zksync-era Feb 9, 2024
@yorik yorik deleted the ya-fix-releases3 branch May 30, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants