fix: use gauge instead histogram for replication lag metric #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBrodetski
approved these changes
Oct 5, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
=======================================
Coverage 31.58% 31.59%
=======================================
Files 478 478
Lines 25463 25463
=======================================
+ Hits 8043 8044 +1
+ Misses 17420 17419 -1
☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- ## [15.1.1](core-v15.1.0...core-v15.1.1) (2023-10-05) ### Bug Fixes * use gauge instead histogram for replication lag metric ([#159](#159)) ([0d952d4](0d952d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Danil <[email protected]>
hatemosphere
pushed a commit
that referenced
this pull request
Oct 6, 2023
🤖 I have created a release *beep* *boop* --- ## [15.1.1](core-v15.1.0...core-v15.1.1) (2023-10-05) ### Bug Fixes * use gauge instead histogram for replication lag metric ([#159](#159)) ([0d952d4](0d952d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Danil <[email protected]>
Oppen
referenced
this pull request
in lambdaclass/zksync-era
Feb 9, 2024
Co-authored-by: vladbochok <[email protected]> Co-authored-by: AntonD3 <[email protected]> Co-authored-by: Vlad Bochok <[email protected]> Co-authored-by: koloz <[email protected]> Co-authored-by: AntonD3 <[email protected]> Co-authored-by: Bence Haromi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.