Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boojum): added flag to control prover selection at genesis #158

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Oct 4, 2023

What ❔

  • Added CONTRACTS_PROVER_AT_GENESIS flag to control which prover should be used during genesis
  • Updated zk status command to compare the keys in the database and in the contracts

Why ❔

  • without this flag, we were pushing the old keys to the contracts, which resulted in failed proofs.

@mm-zk mm-zk requested a review from a team as a code owner October 4, 2023 19:27
@mm-zk mm-zk requested review from joonazan, ly0va and a team and removed request for a team October 4, 2023 19:27
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1625ec2) 32.16% compared to head (957ea0d) 32.17%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           boojum-integration     #158      +/-   ##
======================================================
+ Coverage               32.16%   32.17%   +0.01%     
======================================================
  Files                     482      482              
  Lines                   25929    25930       +1     
======================================================
+ Hits                     8341     8344       +3     
+ Misses                  17588    17586       -2     
Files Coverage Δ
core/lib/config/src/configs/contracts.rs 100.00% <ø> (ø)
core/lib/zksync_core/src/lib.rs 27.15% <ø> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ly0va ly0va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mm-zk mm-zk merged commit 867f2bf into boojum-integration Oct 5, 2023
@mm-zk mm-zk deleted the mmzk_1004_flag_for_prover branch October 5, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants