Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): Witness change for snark wrapper, updated keys #151

Merged
merged 4 commits into from
Oct 4, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Oct 4, 2023

What ❔

  • Changed witness for snark wrapper - to pass the previous AUX and META fields
  • updated snark_wrapper_verification key to the latest version
  • updated the vk_hash to match the newly generated JSON, and made sure that it is being loaded at genesis.

Why ❔

  • to make boojnet work locally

@mm-zk mm-zk requested a review from a team as a code owner October 4, 2023 07:31
@mm-zk mm-zk requested review from porteradams12, ly0va and StanislavBreadless and removed request for a team October 4, 2023 07:31
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (83ac4cf) 32.11% compared to head (8e3a26e) 32.16%.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           boojum-integration     #151      +/-   ##
======================================================
+ Coverage               32.11%   32.16%   +0.04%     
======================================================
  Files                     482      482              
  Lines                   25923    25923              
======================================================
+ Hits                     8326     8337      +11     
+ Misses                  17597    17586      -11     
Files Coverage Δ
core/lib/zksync_core/src/lib.rs 27.15% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ly0va
Copy link
Member

ly0va commented Oct 4, 2023

We can merge this, but I'll need to update #142 after

@mm-zk mm-zk merged commit 2a5c072 into boojum-integration Oct 4, 2023
ilitteri added a commit that referenced this pull request Feb 23, 2024
…oesn't pollute L1BatchPublishCriterion interface (#151)
@mm-zk mm-zk deleted the mmzk_1004_boojum_verification_scheduler branch August 5, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants