Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add exec to replace shell inside entrypoint with the actual binary #134

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

hatemosphere
Copy link
Member

@hatemosphere hatemosphere commented Oct 2, 2023

What ❔

Replaces container shell with EN and local-env executables in corresponding Docker images to eg. properly handle termination signals.

More details in original PR: #76

Courtesy of https://github.com/voron
Thanks for the contribution, and sorry it took so long to review - we've been busy with FOSS'ing our repos.

Why ❔

#76 (comment)

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@hatemosphere hatemosphere requested a review from a team as a code owner October 2, 2023 11:40
@hatemosphere hatemosphere changed the title Add exec to replace shell inside entrypoint with the actual binary fix: Add exec to replace shell inside entrypoint with the actual binary Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (38d66b1) 31.59% compared to head (2e3f19e) 31.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   31.59%   31.56%   -0.03%     
==========================================
  Files         477      477              
  Lines       25429    25429              
==========================================
- Hits         8034     8027       -7     
- Misses      17395    17402       +7     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hatemosphere hatemosphere added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@hatemosphere hatemosphere added this pull request to the merge queue Oct 6, 2023
@hatemosphere hatemosphere removed this pull request from the merge queue due to a manual request Oct 6, 2023
@hatemosphere hatemosphere added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit f94b819 Oct 6, 2023
Oppen referenced this pull request in lambdaclass/zksync-era Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants