Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow state override on eth_estimateGas #947

Open
antonydenyer opened this issue Jan 25, 2024 · 2 comments
Open

Allow state override on eth_estimateGas #947

antonydenyer opened this issue Jan 25, 2024 · 2 comments

Comments

@antonydenyer
Copy link

🌟 Feature Request

📝 Description

Feature parity with geth ethereum/go-ethereum#27800

🤔 Rationale

Currently, you can not perform an eth_estimateGas on something that isn't in the 'correct' state as the evm will, correctly, return an error. For example, on an erc20 you may wish to send an approve followed by a transfer call. You can estimate gas for the approve but not the transfer.

📋 Additional Context

You can make multiple eth_call to get the same result, but getting the node to do it is much better!
@jcarlo-vs
Copy link

looking forward on this feature request. 👍

@EmilLuta
Copy link
Contributor

cc: @Deniallugo, @perekopskiy

@aon aon mentioned this issue Mar 5, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 22, 2024
@aon @Jrigada @Deniallugo
feat: add state override for gas estimates (#1358)
761bda1 
## What ❔

- Adds state override for gas estimates

## Why ❔

- Solves #947 
- Feature parity with geth
ethereum/go-ethereum#27800

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [x] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
- [x] Spellcheck has been run via `zk spellcheck`.
- [x] Linkcheck has been run via `zk linkcheck`.

---------

Co-authored-by: Juan Rigada <[email protected]>
Co-authored-by: Jrigada <[email protected]>
Co-authored-by: Danil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antonydenyer @EmilLuta @jcarlo-vs