Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-index): Add missing index from FRI prover jobs #334

Merged
merged 7 commits into from
Oct 27, 2023

Conversation

akash-chandrakar
Copy link
Contributor

@akash-chandrakar akash-chandrakar commented Oct 27, 2023

What ❔

Add missing index from FRI prover job

Why ❔

Required to run query efficiently

Checklist

  • [ *] PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • [ *] Tests for the changes have been added / updated.
  • [ *] Documentation comments have been added / updated.
  • [ *] Code has been formatted via zk fmt and zk lint.

@akash-chandrakar akash-chandrakar marked this pull request as ready for review October 27, 2023 07:52
@akash-chandrakar akash-chandrakar requested a review from a team as a code owner October 27, 2023 07:52
EmilLuta
EmilLuta previously approved these changes Oct 27, 2023
@akash-chandrakar akash-chandrakar added this pull request to the merge queue Oct 27, 2023
@akash-chandrakar akash-chandrakar removed this pull request from the merge queue due to a manual request Oct 27, 2023
@akash-chandrakar akash-chandrakar changed the title fix(db-index): Add missing index from FRI prover job retry fix(db-index): Add missing index from FRI prover jobs Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eefaad0) 35.83% compared to head (a3572d9) 35.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   35.83%   35.86%   +0.02%     
==========================================
  Files         521      521              
  Lines       27844    27844              
==========================================
+ Hits         9979     9987       +8     
+ Misses      17865    17857       -8     
Files Coverage Δ
core/lib/dal/src/fri_prover_dal.rs 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akash-chandrakar akash-chandrakar added this pull request to the merge queue Oct 27, 2023
Merged via the queue into main with commit 730447f Oct 27, 2023
24 checks passed
@akash-chandrakar akash-chandrakar deleted the add-missing-index branch October 27, 2023 11:36
github-merge-queue bot pushed a commit that referenced this pull request Nov 3, 2023
🤖 I have created a release *beep* *boop*
---


##
[17.1.0](core-v16.2.0...core-v17.1.0)
(2023-11-03)


### ⚠ BREAKING CHANGES

* Update to protocol version 17
([#384](#384))

### Features

* **en:** Cache blocks in `fetch_l2_block`
([#403](#403))
([b94c845](b94c845))
* Port boojum eth-sender changes
([#293](#293))
([8027326](8027326))
* **state-keeper:** Disable some seal criteria for boojum
([#390](#390))
([2343532](2343532))
* Update to protocol version 17
([#384](#384))
([ba271a5](ba271a5))
* **vm:** Make calculation for pubdata a bit more percise
([#392](#392))
([6d0e61c](6d0e61c))


### Bug Fixes

* bump zksolc from yanked version to 1.3.16
([#348](#348))
([c32b88f](c32b88f))
* **db-index:** Add missing index from FRI prover jobs
([#334](#334))
([730447f](730447f))
* **db-query:** use join instead of nested query for FRI prover
extracting
([#364](#364))
([f9cc831](f9cc831))
* **db-query:** use nested query for requeuing FRI prover jobs
([#399](#399))
([3890542](3890542))
* incorrect directory of intrinsic.rs generated.
([#332](#332))
([#336](#336))
([eefaad0](eefaad0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: perekopskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants