Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add yParity for non-legacy transactions #3245

Closed
itegulov opened this issue Nov 11, 2024 · 0 comments · Fixed by #3246
Closed

Add yParity for non-legacy transactions #3245

itegulov opened this issue Nov 11, 2024 · 0 comments · Fixed by #3246
Assignees
@itegulov

Comments

@itegulov
Copy link
Contributor

Non-legacy transactions are supposed to have yParity set to either 0 or 1 (required field). See https://github.com/ethereum/execution-apis/blob/main/src/schemas/transaction.yaml#L264.
@itegulov itegulov self-assigned this Nov 11, 2024
@itegulov itegulov mentioned this issue Nov 11, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 11, 2024
@itegulov
feat(api-server): add yParity for non-legacy txs (#3246)
6ea36d1 
## What ❔

Closes #3245

## Why ❔

See #3245 for more details. TLDR better compatibility with ETH spec.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [x] Documentation comments have been added / updated.
- [x] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itegulov itegulov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api-server): add yParity for non-legacy txs matter-labs/zksync-era
1 participant
@itegulov