Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Base token): add cbt metrics #2720

Merged
merged 9 commits into from
Aug 23, 2024
Merged

feat(Base token): add cbt metrics #2720

merged 9 commits into from
Aug 23, 2024

Conversation

ischasny
Copy link
Collaborator

  • Add cbt-related metrics;
  • Move last hardcoded cbt-related properties to the config.

RomanBrodetski
RomanBrodetski previously approved these changes Aug 23, 2024
Copy link
Collaborator

@RomanBrodetski RomanBrodetski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but please consider my comments

@RomanBrodetski RomanBrodetski changed the title feat: add cbt metrics feat(Base token): add cbt metrics Aug 23, 2024
RomanBrodetski
RomanBrodetski previously approved these changes Aug 23, 2024
@ischasny ischasny enabled auto-merge August 23, 2024 13:17
@ischasny ischasny dismissed stale reviews from RomanBrodetski and perekopskiy via 90170b6 August 23, 2024 14:45
@ischasny ischasny added this pull request to the merge queue Aug 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2024
@ischasny ischasny added this pull request to the merge queue Aug 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 23, 2024
@ischasny ischasny added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 58438eb Aug 23, 2024
49 checks passed
@ischasny ischasny deleted the ivan/add-cbt-metrics branch August 23, 2024 18:18
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.22.0](core-v24.21.0...core-v24.22.0)
(2024-08-27)


### Features

* add flag to enable/disable DA inclusion verification
([#2647](#2647))
([b425561](b425561))
* **Base token:** add cbt metrics
([#2720](#2720))
([58438eb](58438eb))
* Change default_protective_reads_persistence_enabled to false
([#2716](#2716))
([8d0eee7](8d0eee7))
* **vm:** Extract oneshot VM executor interface
([#2671](#2671))
([951d5f2](951d5f2))
* **zk_toolbox:** Add holesky testnet as layer1 network
([#2632](#2632))
([d9266e5](d9266e5))


### Bug Fixes

* **api:** `tx.gas_price` field
([#2734](#2734))
([aea3726](aea3726))
* **base_token_adjuster:** bug with a wrong metrics namespace
([#2744](#2744))
([64b2ff8](64b2ff8))
* **eth-sender:** missing Gateway migration changes
([#2732](#2732))
([a4170e9](a4170e9))
* **proof_data_handler:** TEE blob fetching error handling
([#2674](#2674))
([c162510](c162510))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants