Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk init error #26

Closed
GrapeBaBa opened this issue Apr 19, 2023 · 3 comments
Closed

zk init error #26

GrapeBaBa opened this issue Apr 19, 2023 · 3 comments

Comments

@GrapeBaBa
Copy link

  Compiling zkevm_test_harness v1.3.1 (https://github.com/matter-labs/era-zkevm_test_harness.git?branch=main#cfac36a3)
error[E0046]: not all trait items implemented, missing: `report_new_callstack_frame`
    --> /Users/kaichen/.cargo/git/checkouts/era-zkevm_test_harness-22d97ff2abf02d7d/cfac36a/src/witness/oracle.rs:1250:1
     |
1250 | impl<E: Engine> WitnessOracle<E> for VmWitnessOracle<E> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `report_new_callstack_frame` in implementation
     |
     = help: implement the missing item: `fn report_new_callstack_frame(&mut self, _: &ExecutionContextRecord<E>, _: sync_vm::vm::primitives::UInt32<E>, _: &sync_vm::franklin_crypto::plonk::circuit::boolean::Boolean, _: &sync_vm::franklin_crypto::plonk::circuit::boolean::Boolean) { todo!() }`

For more information about this error, try `rustc --explain E0046`.
error: could not compile `zkevm_test_harness` due to previous error
error: `cargo check` failed with status: exit status: 101
   Compiling zkevm_test_harness v1.3.1 (https://github.com/matter-labs/era-zkevm_test_harness.git?branch=main#cfac36a3)
error[E0046]: not all trait items implemented, missing: `report_new_callstack_frame`
    --> /Users/kaichen/.cargo/git/checkouts/era-zkevm_test_harness-22d97ff2abf02d7d/cfac36a/src/witness/oracle.rs:1250:1
     |
1250 | impl<E: Engine> WitnessOracle<E> for VmWitnessOracle<E> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `report_new_callstack_frame` in implementation
     |
     = help: implement the missing item: `fn report_new_callstack_frame(&mut self, _: &ExecutionContextRecord<E>, _: sync_vm::vm::primitives::UInt32<E>, _: &sync_vm::franklin_crypto::plonk::circuit::boolean::Boolean, _: &sync_vm::franklin_crypto::plonk::circuit::boolean::Boolean) { todo!() }`

For more information about this error, try `rustc --explain E0046`.
error: could not compile `zkevm_test_harness` due to previous error
error: `cargo check` failed with status: exit status: 101
Error: Child process exited with code 1
@oday0311
Copy link

some issue, Mac M1

@oday0311
Copy link

i found this , but still need logic code.fn
matter-labs/era-zkevm_test_harness#3

report_new_callstack_frame(
&mut self,
new_callstack: &ExecutionContextRecord,
new_depth: UInt32,
is_call: &Boolean,
execute: &Boolean,
) {
// TODO: need implementation
}

@shahar4
Copy link
Collaborator

shahar4 commented Jun 2, 2023

Sorry for the inconvenience! This was indeed the issue and the fix is now reflected in the updated code.

@shahar4 shahar4 closed this as completed Jun 2, 2023
StanislavBreadless pushed a commit that referenced this issue Dec 19, 2024
chore: clean up and restore some tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants