-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove old EN code #2595
Merged
Merged
feat: Remove old EN code #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I have looked that deep into whether framework-based initialization works identical to the legacy approach, but overall it looks good.
core/node/node_framework/src/implementations/layers/node_storage_init/external_node_strategy.rs
Outdated
Show resolved
Hide resolved
perekopskiy
previously approved these changes
Aug 8, 2024
slowli
previously approved these changes
Aug 8, 2024
slowli
previously approved these changes
Aug 9, 2024
slowli
approved these changes
Aug 12, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
🤖 I have created a release *beep* *boop* --- ## [24.17.0](core-v24.16.0...core-v24.17.0) (2024-08-13) ### Features * Allow tracking l2 fees for L2-based chains ([#2563](#2563)) ([e3f7804](e3f7804)) * Remove old EN code ([#2595](#2595)) ([8d31ebc](8d31ebc)) * **tee:** introduce get_tee_proofs RPC method for TEE proofs ([#2474](#2474)) ([d40ff5f](d40ff5f)) * **vm:** Fast VM integration ([#1949](#1949)) ([b752a54](b752a54)) ### Bug Fixes * query for prover API ([#2628](#2628)) ([b8609eb](b8609eb)) * **vm:** Fix missing experimental VM config ([#2629](#2629)) ([e07a39d](e07a39d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Some changes are not done in this PR to reduce the scope (e.g. removing unneeded dependencies).
Why ❔
Switch to framework.
Checklist
zk fmt
andzk lint
.