Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove old EN code #2595

Merged
merged 6 commits into from
Aug 12, 2024
Merged

feat: Remove old EN code #2595

merged 6 commits into from
Aug 12, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 6, 2024

What ❔

  • Removes old EN code.
  • Some configs weren't used in the framework code by mistake. This is fixed now.
  • Diamond proxy address was made private in config so that it's obtained in a checked manner.

Some changes are not done in this PR to reduce the scope (e.g. removing unneeded dependencies).

Why ❔

Switch to framework.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@popzxc popzxc requested review from slowli and perekopskiy August 6, 2024 08:02
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I have looked that deep into whether framework-based initialization works identical to the legacy approach, but overall it looks good.

perekopskiy
perekopskiy previously approved these changes Aug 8, 2024
slowli
slowli previously approved these changes Aug 8, 2024
core/bin/external_node/src/config/mod.rs Outdated Show resolved Hide resolved
core/bin/external_node/src/config/mod.rs Outdated Show resolved Hide resolved
slowli
slowli previously approved these changes Aug 9, 2024
@popzxc popzxc added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 8d31ebc Aug 12, 2024
48 checks passed
@popzxc popzxc deleted the popzxc-remove-old-en-code branch August 12, 2024 14:31
github-merge-queue bot pushed a commit that referenced this pull request Aug 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.17.0](core-v24.16.0...core-v24.17.0)
(2024-08-13)


### Features

* Allow tracking l2 fees for L2-based chains
([#2563](#2563))
([e3f7804](e3f7804))
* Remove old EN code
([#2595](#2595))
([8d31ebc](8d31ebc))
* **tee:** introduce get_tee_proofs RPC method for TEE proofs
([#2474](#2474))
([d40ff5f](d40ff5f))
* **vm:** Fast VM integration
([#1949](#1949))
([b752a54](b752a54))


### Bug Fixes

* query for prover API
([#2628](#2628))
([b8609eb](b8609eb))
* **vm:** Fix missing experimental VM config
([#2629](#2629))
([e07a39d](e07a39d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants