Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prover): Fix NWG #2590

Merged
merged 8 commits into from
Aug 7, 2024
Merged

fix(prover): Fix NWG #2590

merged 8 commits into from
Aug 7, 2024

Conversation

0xVolosnikov
Copy link
Contributor

Invalid repacking of proofs for processing and invalid assertion do not allow to complete NWG.

@0xVolosnikov 0xVolosnikov requested a review from EmilLuta August 5, 2024 10:43
@0xVolosnikov 0xVolosnikov marked this pull request as draft August 5, 2024 12:09
@0xVolosnikov 0xVolosnikov marked this pull request as ready for review August 5, 2024 12:37
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left a few nits. Can be addressed with a follow-up PR.

I'd suggest we test these locally before merging.

@EmilLuta EmilLuta added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 9b58ae9 Aug 7, 2024
26 checks passed
@EmilLuta EmilLuta deleted the vv-fix-nwg branch August 7, 2024 08:23
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2024
🤖 I have created a release *beep* *boop*
---


##
[16.3.0](prover-v16.2.0...prover-v16.3.0)
(2024-08-07)


### Features

* Poll the main node API for attestation status - relaxed (BFT-496)
([#2583](#2583))
([b45aa91](b45aa91))


### Bug Fixes

* **prover:** Fix NWG
([#2590](#2590))
([9b58ae9](9b58ae9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: EmilLuta <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[16.4.0](prover-v16.3.0...prover-v16.4.0)
(2024-08-16)


### Features

* Bump harness & gpu deps
([#2634](#2634))
([2a7d566](2a7d566))
* Poll the main node API for attestation status - relaxed (BFT-496)
([#2583](#2583))
([b45aa91](b45aa91))
* **vlog:** Report observability config, flush, and shutdown
([#2622](#2622))
([e23e661](e23e661))
* **vm:** Extract VM interface to separate crate
([#2638](#2638))
([cb9ac4e](cb9ac4e))
* **vm:** Fast VM integration
([#1949](#1949))
([b752a54](b752a54))


### Bug Fixes

* Bump prover dependencies & rust toolchain
([#2600](#2600))
([849c6a5](849c6a5))
* **prover:** Fix NWG
([#2590](#2590))
([9b58ae9](9b58ae9))
* **prover:** Updated README.md
([#2604](#2604))
([be9f357](be9f357))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants