-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: External prover API #2538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artemka374
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet,
otani88 and
iluwaa
July 31, 2024 05:46
popzxc
reviewed
Jul 31, 2024
EmilLuta
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moves in the right direction. The queuing logic needs some work, and there's a bit of duplication (easy to get rid of, not a big deal) but otherwise looks good.
core/node/node_framework/src/implementations/layers/prover_api.rs
Outdated
Show resolved
Hide resolved
# Conflicts: # core/lib/protobuf_config/src/general.rs
EmilLuta
reviewed
Aug 1, 2024
EmilLuta
previously approved these changes
Aug 8, 2024
Co-authored-by: EmilLuta <[email protected]>
EmilLuta
approved these changes
Aug 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
🤖 I have created a release *beep* *boop* --- ## [24.16.0](core-v24.15.0...core-v24.16.0) (2024-08-08) ### Features * External prover API ([#2538](#2538)) ([129a181](129a181)) * **node-framework:** Add API fee params resource ([#2621](#2621)) ([aff7b65](aff7b65)) * **vlog:** Expose more resource values via opentelemetry ([#2620](#2620)) ([7ae07e4](7ae07e4)) * **vlog:** Report observability config, flush, and shutdown ([#2622](#2622)) ([e23e661](e23e661)) ### Bug Fixes * Bump prover dependencies & rust toolchain ([#2600](#2600)) ([849c6a5](849c6a5)) * **en:** Initialize SyncState in OutputHandler ([#2618](#2618)) ([f0c8506](f0c8506)) * restrictive genesis parsing ([#2605](#2605)) ([d5f8f38](d5f8f38)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds prover API component, which allows to get proof generation data and verify final proofs against generated by our prover subsystem.
Why ❔
First step of prover decentralization.
Checklist
zk fmt
andzk lint
.