Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: External prover API #2538

Merged
merged 25 commits into from
Aug 8, 2024
Merged

feat: External prover API #2538

merged 25 commits into from
Aug 8, 2024

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented Jul 30, 2024

What ❔

Adds prover API component, which allows to get proof generation data and verify final proofs against generated by our prover subsystem.

Why ❔

First step of prover decentralization.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@Artemka374 Artemka374 changed the title feat: External prover API feat: [WIP]External prover API Jul 30, 2024
@Artemka374 Artemka374 marked this pull request as draft July 30, 2024 08:34
@Artemka374 Artemka374 changed the title feat: [WIP]External prover API feat: External prover API Jul 30, 2024
@Artemka374 Artemka374 marked this pull request as ready for review July 31, 2024 05:13
@EmilLuta EmilLuta requested review from popzxc and EmilLuta July 31, 2024 07:16
Cargo.toml Outdated Show resolved Hide resolved
core/lib/dal/src/proof_generation_dal.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/processor.rs Outdated Show resolved Hide resolved
etc/env/file_based/general.yaml Outdated Show resolved Hide resolved
core/node/prover_api/src/lib.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves in the right direction. The queuing logic needs some work, and there's a bit of duplication (easy to get rid of, not a big deal) but otherwise looks good.

.github/workflows/ci-core-reusable.yml Outdated Show resolved Hide resolved
core/lib/config/src/configs/prover_api.rs Outdated Show resolved Hide resolved
core/lib/dal/src/proof_generation_dal.rs Outdated Show resolved Hide resolved
core/lib/dal/src/proof_generation_dal.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/lib.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/lib.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/processor.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/processor.rs Outdated Show resolved Hide resolved
# Conflicts:
#	core/lib/protobuf_config/src/general.rs
core/lib/dal/src/proof_generation_dal.rs Show resolved Hide resolved
core/node/prover_api/src/error.rs Outdated Show resolved Hide resolved
core/node/prover_api/src/error.rs Outdated Show resolved Hide resolved
core/lib/dal/src/proof_generation_dal.rs Outdated Show resolved Hide resolved
EmilLuta
EmilLuta previously approved these changes Aug 8, 2024
@Artemka374 Artemka374 enabled auto-merge August 8, 2024 13:09
@Artemka374 Artemka374 added this pull request to the merge queue Aug 8, 2024
Merged via the queue into main with commit 129a181 Aug 8, 2024
53 checks passed
@Artemka374 Artemka374 deleted the afo/epp branch August 8, 2024 13:44
github-merge-queue bot pushed a commit that referenced this pull request Aug 8, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.16.0](core-v24.15.0...core-v24.16.0)
(2024-08-08)


### Features

* External prover API
([#2538](#2538))
([129a181](129a181))
* **node-framework:** Add API fee params resource
([#2621](#2621))
([aff7b65](aff7b65))
* **vlog:** Expose more resource values via opentelemetry
([#2620](#2620))
([7ae07e4](7ae07e4))
* **vlog:** Report observability config, flush, and shutdown
([#2622](#2622))
([e23e661](e23e661))


### Bug Fixes

* Bump prover dependencies & rust toolchain
([#2600](#2600))
([849c6a5](849c6a5))
* **en:** Initialize SyncState in OutputHandler
([#2618](#2618))
([f0c8506](f0c8506))
* restrictive genesis parsing
([#2605](#2605))
([d5f8f38](d5f8f38))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants