feat(Prover CLI): `status batch` command #1638

ColoCarletti · 2024-04-10T19:14:01Z

What ❔

This PR adds a new command to the prover CLI: 'status batch'. This command retrieves information about the prover jobs for a list of L1 batch numbers.

To run the command:

zk f cargo run -- status batch -n [1..]

This command accepts any number of L1 batch numbers.

Example output:

$ zk f run --release -- status batch -n 1

== Batch 1 Status ==
> In Progress ⌛️

== Proving Stages ==
-- Aggregaton Round 0 --
Basic Witness Generator: Done ✅
> Prover Jobs: In progress ⌛️

-- Aggregaton Round 1 --
Leaf Witness Generator: In progress ⌛️
> Prover Jobs: Waiting for proofs ⏱️

-- Aggregaton Round 2 --
Node Witness Generator: In progress ⌛️
> Prover Jobs: Waiting for proofs ⏱️

-- Aggregaton Round 3 --
Recursion Tip: In progress ⌛️
> Prover Jobs: Waiting for proofs ⏱️

-- Aggregaton Round 4 --
Scheduler: In progress ⌛️
> Prover Jobs: Waiting for proofs ⏱️

-- Compressor --
> Compressor job not found 🚫

Please note that this command is temporary. Once the new zk tool is ready, this command will be something like 'pli status batch -n 1 2'. For now, the 'zk' tool is needed to set up the environment.

Checklist

PR title corresponds to the body of PR (we generate changelog entries from PRs).
Tests for the changes have been added / updated.
Documentation comments have been added / updated.
Code has been formatted via zk fmt and zk lint.
Spellcheck has been run via zk spellcheck.
Linkcheck has been run via zk linkcheck.

prover/prover_cli/src/commands/get_proof_progress.rs

ilitteri

LGTM for now, I think this command will change a little bit in the future when the status command is correctly isolated. Also tests for this command can be added in another PR (but asap).

prover/prover_cli/Cargo.toml

…sync-era into prover_cli_status_command

…sync-era into prover_cli_status_command_lwg

…s/zksync-era into prover_cli_status_command_lwg

feat(Prover CLI): status command lwg

core/lib/basic_types/src/prover_dal.rs

core/lib/basic_types/Cargo.toml

🤖 I have created a release *beep* *boop* --- ## [14.0.0](prover-v13.0.0...prover-v14.0.0) (2024-05-06) ### ⚠ BREAKING CHANGES * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) * shared bridge ([#298](#298)) ### Features * **config:** Wrap sensitive urls ([#1828](#1828)) ([c8ee740](c8ee740)) * **Prover CLI:** `status batch` command ([#1638](#1638)) ([3fd6d65](3fd6d65)) * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) ([6a557f7](6a557f7)) * **prover:** remove redundant config fields ([#1787](#1787)) ([a784ea6](a784ea6)) * shared bridge ([#298](#298)) ([8c3478a](8c3478a)) * **vm-runner:** implement VM runner storage layer ([#1651](#1651)) ([543f9e9](543f9e9)) ### Bug Fixes * **en:** Remove duplicate reorg detector ([#1783](#1783)) ([3417941](3417941)) * **prover:** Use all 1.5.0 groups for nodes ([#1851](#1851)) ([70178e5](70178e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

## What ❔ This PR adds a new command to the prover CLI: 'status batch'. This command retrieves information about the prover jobs for a list of L1 batch numbers. To run the command: ```shell zk f cargo run -- status batch -n [1..] ``` This command accepts any number of L1 batch numbers. Example output: ``` $ zk f run --release -- status batch -n 1 == Batch 1 Status == > In Progress ⌛️ == Proving Stages == -- Aggregaton Round 0 -- Basic Witness Generator: Done ✅ > Prover Jobs: In progress ⌛️ -- Aggregaton Round 1 -- Leaf Witness Generator: In progress ⌛️ > Prover Jobs: Waiting for proofs ⏱️ -- Aggregaton Round 2 -- Node Witness Generator: In progress ⌛️ > Prover Jobs: Waiting for proofs ⏱️ -- Aggregaton Round 3 -- Recursion Tip: In progress ⌛️ > Prover Jobs: Waiting for proofs ⏱️ -- Aggregaton Round 4 -- Scheduler: In progress ⌛️ > Prover Jobs: Waiting for proofs ⏱️ -- Compressor -- > Compressor job not found 🚫 ``` Please note that this command is temporary. Once the new `zk` tool is ready, this command will be something like 'pli status batch -n 1 2'. For now, the 'zk' tool is needed to set up the environment. ## Checklist   - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`. --------- Co-authored-by: Joaquin Carletti <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: ilitteri <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [14.0.0](prover-v13.0.0...prover-v14.0.0) (2024-05-06) ### ⚠ BREAKING CHANGES * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) * shared bridge ([#298](#298)) ### Features * **config:** Wrap sensitive urls ([#1828](#1828)) ([c8ee740](c8ee740)) * **Prover CLI:** `status batch` command ([#1638](#1638)) ([3fd6d65](3fd6d65)) * **prover:** Protocol Upgrade 1.5.0 ([#1699](#1699)) ([6a557f7](6a557f7)) * **prover:** remove redundant config fields ([#1787](#1787)) ([a784ea6](a784ea6)) * shared bridge ([#298](#298)) ([8c3478a](8c3478a)) * **vm-runner:** implement VM runner storage layer ([#1651](#1651)) ([543f9e9](543f9e9)) ### Bug Fixes * **en:** Remove duplicate reorg detector ([#1783](#1783)) ([3417941](3417941)) * **prover:** Use all 1.5.0 groups for nodes ([#1851](#1851)) ([70178e5](70178e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [24.1.0](core-v24.0.0...core-v24.1.0) (2024-05-08) ### Features * add `sendRawTransactionWithDetailedOutput` API ([#1806](#1806)) ([6a30a31](6a30a31)) * add getGasPerPubdataByte endpoint ([#1778](#1778)) ([d62dd08](d62dd08)) * **config:** Wrap sensitive urls ([#1828](#1828)) ([c8ee740](c8ee740)) * **db:** Implement weak references to RocksDB ([e0d4daa](e0d4daa)) * **en:** Add pruning health checks and rework pruning config ([#1790](#1790)) ([e0d4daa](e0d4daa)) * Extract proof_data_handler into separate crate ([#1677](#1677)) ([f4facee](f4facee)) * Extract several crates from zksync_core ([#1859](#1859)) ([7dcf796](7dcf796)) * **node:** Extract genesis into separate crate ([#1797](#1797)) ([a8c4599](a8c4599)) * **Prover CLI:** `status batch` command ([#1638](#1638)) ([3fd6d65](3fd6d65)) * prover components versioning ([#1660](#1660)) ([29a4ffc](29a4ffc)) * Update provers current version ([#1872](#1872)) ([bb5f129](bb5f129)) ### Bug Fixes * **basic_types:** bincode deserialization for `L2ChainId` ([#1835](#1835)) ([fde85f4](fde85f4)) * **contract-verifier:** YUL system-mode verification ([#1863](#1863)) ([5aa7d41](5aa7d41)) * **loadtest:** Do not initiate transactions with 0 amount ([#1847](#1847)) ([1bbe108](1bbe108)) ### Performance Improvements * **db:** Fine-tune state keeper cache performance / RAM usage ([#1804](#1804)) ([82bf40e](82bf40e)) * **state-keeper:** Improve `FilterWrittenSlots` l1 batch seal stage ([#1854](#1854)) ([4cf235f](4cf235f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: perekopskiy <[email protected]>

ColoCarletti added 8 commits April 8, 2024 13:42

fmt

17e564c

wip

245b0a4

add cargo.toml cargo.lock

8e84243

go back to anihow

17517b1

fmt

4ab7ce8

rm tool workspace

4655201

fmt

c32d1aa

zk fmt

8e49e04

ColoCarletti changed the title ~~Prover cli status command~~ feat: prover cli status command Apr 10, 2024

fix typo

80e13da

ilitteri changed the title ~~feat: prover cli status command~~ feat(Prover CLI): get-proof-status command Apr 11, 2024

Artemka374 reviewed Apr 11, 2024

View reviewed changes

prover/prover_cli/src/commands/get_proof_progress.rs Outdated Show resolved Hide resolved

prover/prover_cli/src/commands/get_proof_progress.rs Outdated Show resolved Hide resolved

prover/prover_cli/src/commands/get_proof_progress.rs Outdated Show resolved Hide resolved

Base automatically changed from feat_prover_cli to main April 11, 2024 14:37

ColoCarletti and others added 2 commits April 12, 2024 18:51

move query to prover_dal

0f2ebd8

remove --all flag

69d2104

ColoCarletti requested a review from ilitteri April 15, 2024 21:21

ColoCarletti added 4 commits April 16, 2024 11:12

change command name

c9e6e5e

merge main

83fab40

fmt

cdbb467

add sqlx query json

d1f3994

ColoCarletti changed the title ~~feat(Prover CLI): get-proof-status command~~ feat(Prover CLI): status-jobs command Apr 16, 2024

ilitteri previously approved these changes Apr 16, 2024

View reviewed changes

prover/prover_cli/Cargo.toml Show resolved Hide resolved

ilitteri marked this pull request as ready for review April 16, 2024 15:29

Merge branch 'main' into prover_cli_status_command

4ee3ff2

ilitteri requested review from Artemka374 and EmilLuta April 16, 2024 15:29

ColoCarletti added 3 commits April 16, 2024 12:36

update README

fff3910

zk fmt

ef906b9

Merge branch 'prover_cli_status_command' of github.com:matter-labs/zk…

3758547

…sync-era into prover_cli_status_command

ColoCarletti dismissed ilitteri’s stale review via 3758547 April 16, 2024 15:38

ilitteri and others added 10 commits April 30, 2024 16:10

Merge branch 'prover_cli_status_command' of github.com:matter-labs/zk…

1efde33

…sync-era into prover_cli_status_command_lwg

fix import

112ae93

zk lint rust

e1854fa

Merge branch 'prover_cli_status_command_lwg' of github.com:matter-lab…

ccab3d3

…s/zksync-era into prover_cli_status_command_lwg

fix wg task types

fa26c26

Merge pull request #1830 from matter-labs/prover_cli_status_command_lwg

dbaf3b4

feat(Prover CLI): status command lwg

Merge main

4124f63

update README

a4fde1f

fix EIP Blob use

10fdcb9

fix typos

8a1101f

ColoCarletti marked this pull request as ready for review May 1, 2024 04:17

ilitteri and others added 4 commits May 2, 2024 09:27

Merge branch 'main' into prover_cli_status_command

c1282a5

Fix typo

1bbde93

Merge branch 'main' into prover_cli_status_command

16be778

Merge branch 'main' into prover_cli_status_command

1810ae0

EmilLuta reviewed May 2, 2024

View reviewed changes

core/lib/basic_types/src/prover_dal.rs Show resolved Hide resolved

EmilLuta reviewed May 2, 2024

View reviewed changes

core/lib/basic_types/Cargo.toml Outdated Show resolved Hide resolved

update cargo.toml

6f45f43

ColoCarletti requested a review from EmilLuta May 2, 2024 21:33

EmilLuta approved these changes May 3, 2024

View reviewed changes

EmilLuta added this pull request to the merge queue May 3, 2024

Merged via the queue into main with commit 3fd6d65 May 3, 2024
43 checks passed

EmilLuta deleted the prover_cli_status_command branch May 3, 2024 13:07

This was referenced May 3, 2024

chore(main): release prover 14.0.0 #1772

Merged

chore(main): release core 24.1.0 #1836

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Prover CLI): `status batch` command #1638

feat(Prover CLI): `status batch` command #1638

ColoCarletti commented Apr 10, 2024 •

edited

Loading

ilitteri left a comment

feat(Prover CLI): status batch command #1638

feat(Prover CLI): status batch command #1638

Conversation

ColoCarletti commented Apr 10, 2024 • edited Loading

What ❔

Checklist

ilitteri left a comment

Choose a reason for hiding this comment

feat(Prover CLI): `status batch` command #1638

feat(Prover CLI): `status batch` command #1638

ColoCarletti commented Apr 10, 2024 •

edited

Loading