feat: add state override for gas estimates #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
reviewed
Mar 5, 2024
Deniallugo
reviewed
Mar 6, 2024
Deniallugo
reviewed
Mar 7, 2024
There was a problem hiding this comment.
I'm waiting for a full implementation..
I'm a bit of concerned, that we have take into account such a lot of places outside vm, probably it does make sense to introduce new abstraction where we do override on abstraction level which is deeper than storage view and use this abstraction instead of direct connection to the database
core/lib/zksync_core/src/api_server/web3/backend_jsonrpsee/namespaces/eth.rs
Outdated
Show resolved
Hide resolved
Deniallugo
reviewed
Mar 11, 2024
…ter-labs/zksync-era into aon-add-override-estimate-gas-tracer
Deniallugo
reviewed
Mar 12, 2024
…ter-labs/zksync-era into aon-add-override-estimate-gas-tracer
perekopskiy
reviewed
Jul 1, 2024
…e to eth_call and estimate_fee and estimate_l1_to_l2_gas
perekopskiy
reviewed
Jul 8, 2024
core/tests/ts-integration/contracts/state-override/StateOverrideTest.sol
Outdated
Show resolved
Hide resolved
perekopskiy
approved these changes
Jul 22, 2024
Deniallugo
approved these changes
Jul 22, 2024
No performance difference detected (anymore) |
Jrigada
approved these changes
Jul 22, 2024
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [24.11.0](core-v24.10.0...core-v24.11.0) (2024-07-23) ### Features * add revert tests (external node) to zk_toolbox ([#2408](#2408)) ([3fbbee1](3fbbee1)) * add state override for gas estimates ([#1358](#1358)) ([761bda1](761bda1)) * added consensus_config to general config ([#2462](#2462)) ([c5650a4](c5650a4)) * added key generation command to EN ([#2461](#2461)) ([9861415](9861415)) * remove leftovers after BWIP ([#2456](#2456)) ([990676c](990676c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
## What ❔ Brush up VM storage overrides as introduced in #1358. ## Why ❔ The overrides implementation looks overly complex and isn't correctly localized by domain (located in the `state` crate, while the functionality is API server-specific). This worsens maintainability. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.