Skip to content

Commit

Permalink
Fix workflow command to run vm benchmarks
Browse files Browse the repository at this point in the history
  • Loading branch information
popzxc committed Jun 21, 2024
1 parent 1630593 commit 6d0e291
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/vm-perf-comparison.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ jobs:
run: |
ci_run zk
ci_run zk compiler system-contracts
ci_run cargo bench --package vm-benchmark --bench iai | tee base-iai
ci_run cargo run --package vm-benchmark --release --bin instruction-counts | tee base-opcodes || touch base-opcodes
ci_run cargo bench --package zksync_vm_benchmark --bench iai | tee base-iai
ci_run cargo run --package zksync_vm_benchmark --release --bin instruction-counts | tee base-opcodes || touch base-opcodes
ci_run yarn workspace system-contracts clean
- name: checkout PR
Expand All @@ -58,12 +58,12 @@ jobs:
run: |
ci_run zk
ci_run zk compiler system-contracts
ci_run cargo bench --package vm-benchmark --bench iai | tee pr-iai
ci_run cargo run --package vm-benchmark --release --bin instruction-counts | tee pr-opcodes || touch pr-opcodes
ci_run cargo bench --package zksync_vm_benchmark --bench iai | tee pr-iai
ci_run cargo run --package zksync_vm_benchmark --release --bin instruction-counts | tee pr-opcodes || touch pr-opcodes
EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64)
echo "speedup<<$EOF" >> $GITHUB_OUTPUT
ci_run cargo run --package vm-benchmark --release --bin compare_iai_results base-iai pr-iai base-opcodes pr-opcodes >> $GITHUB_OUTPUT
ci_run cargo run --package zksync_vm_benchmark --release --bin compare_iai_results base-iai pr-iai base-opcodes pr-opcodes >> $GITHUB_OUTPUT
echo "$EOF" >> $GITHUB_OUTPUT
id: comparison

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/vm-perf-to-prometheus.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@ jobs:
- name: run benchmarks
run: |
ci_run cargo bench --package vm-benchmark --bench diy_benchmark
ci_run cargo bench --package vm-benchmark --bench iai | tee iai-result
ci_run cargo run --package vm-benchmark --bin iai_results_to_prometheus --release < iai-result
ci_run cargo bench --package zksync_vm_benchmark --bench diy_benchmark
ci_run cargo bench --package zksync_vm_benchmarkk --bench iai | tee iai-result
ci_run cargo run --package zksync_vm_benchmark --bin iai_results_to_prometheus --release < iai-result

0 comments on commit 6d0e291

Please sign in to comment.