Skip to content

Commit

Permalink
ci: try to fix paths
Browse files Browse the repository at this point in the history
  • Loading branch information
antonbaliasnikov committed Dec 19, 2024
1 parent 2c17151 commit 2a3b548
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 13 deletions.
1 change: 1 addition & 0 deletions .github/workflows/cargo-license.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: EmbarkStudios/cargo-deny-action@8371184bd11e21dcf8ac82ebf8c9c9f74ebf7268 # v2.0.1
with:
manifest-path: "./core/Cargo.toml"
command: check
command-arguments: "--hide-inclusion-graph"
12 changes: 6 additions & 6 deletions .github/workflows/protobuf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ jobs:
- name: checkout LCA
run:
git checkout $(git merge-base $BASE $HEAD) --recurse-submodules
working-directory: ./before
working-directory: ./before/core
- name: compile before
run: cargo check --all-targets
working-directory: ./before/
working-directory: ./before/core
- name: build before.binpb
run: >
perl -ne 'print "$1\n" if /PROTOBUF_DESCRIPTOR="(.*)"/'
`find ./before/target/debug/build/*/output`
| xargs cat > ./before.binpb
`find ./before/core/target/debug/build/*/output`
| xargs cat > ./before/.binpb
# after
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4
Expand All @@ -63,11 +63,11 @@ jobs:
submodules: recursive
- name: compile after
run: cargo check --all-targets
working-directory: ./after
working-directory: ./after/core
- name: build after.binpb
run: >
perl -ne 'print "$1\n" if /PROTOBUF_DESCRIPTOR="(.*)"/'
`find ./after/target/debug/build/*/output`
`find ./after/core/target/debug/build/*/output`
| xargs cat > ./after.binpb
# compare
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/vm-perf-comparison.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ jobs:
run: |
ci_run zkstackup -g --local
ci_run zkstack dev contracts --system-contracts
ci_run cargo bench --package vm-benchmark --bench instructions -- --verbose || echo "Instructions benchmark is missing"
ci_run cargo run --package vm-benchmark --release --bin instruction_counts | tee base-opcodes
ci_run cargo bench --manifest-path ./core/Cargo.toml --package vm-benchmark --bench instructions -- --verbose || echo "Instructions benchmark is missing"
ci_run cargo run --manifest-path ./core/Cargo.toml --package vm-benchmark --release --bin instruction_counts | tee base-opcodes
- name: checkout PR
run: |
Expand All @@ -66,17 +66,17 @@ jobs:
run: |
ci_run zkstackup -g --local
ci_run zkstack dev contracts --system-contracts
ci_run cargo bench --package vm-benchmark --bench instructions -- --verbose
ci_run cargo bench --manifest-path ./core/Cargo.toml --package vm-benchmark --bench instructions -- --verbose
ci_run cargo bench --package vm-benchmark --bench instructions -- --print > instructions.log 2>/dev/null
ci_run cargo bench --manifest-path ./core/Cargo.toml --package vm-benchmark --bench instructions -- --print > instructions.log 2>/dev/null
# Output all lines from the benchmark result starting from the "## ..." comparison header.
# Since the output spans multiple lines, we use a heredoc declaration.
EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64)
echo "speedup<<$EOF" >> $GITHUB_OUTPUT
sed -n '/^## /,$p' instructions.log >> $GITHUB_OUTPUT
echo "$EOF" >> $GITHUB_OUTPUT
ci_run cargo run --package vm-benchmark --release --bin instruction_counts -- --diff base-opcodes > opcodes.log
ci_run cargo run --manifest-path ./core/Cargo.toml --package vm-benchmark --release --bin instruction_counts -- --diff base-opcodes > opcodes.log
echo "opcodes<<$EOF" >> $GITHUB_OUTPUT
sed -n '/^## /,$p' opcodes.log >> $GITHUB_OUTPUT
echo "$EOF" >> $GITHUB_OUTPUT
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ pub fn run(shell: &Shell, args: LintArgs) -> anyhow::Result<()> {
fn lint_rs(shell: &Shell, ecosystem: &EcosystemConfig, check: bool) -> anyhow::Result<()> {
let spinner = Spinner::new(&msg_running_linter_for_extension_spinner(&Target::Rs));

let link_to_code = &ecosystem.link_to_code;
let link_to_code = &ecosystem.link_to_code.join("core");
let lint_to_prover = &ecosystem.link_to_code.join("prover");
let link_to_zkstack = &ecosystem.link_to_code.join("zkstack_cli");

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pub async fn run(shell: &Shell) -> anyhow::Result<()> {
.load_current_chain()
.expect(MSG_CHAIN_NOT_FOUND_ERR);

let link_to_code = ecosystem_config.link_to_code;
let link_to_code = ecosystem_config.link_to_code.join("core");
let link_to_prover = link_to_code.join("prover");

let protocol_version = get_protocol_version(shell, &link_to_prover).await?;
Expand Down

0 comments on commit 2a3b548

Please sign in to comment.