Skip to content

Commit

Permalink
feat: Remove initialize_components function (#2284)
Browse files Browse the repository at this point in the history
## What ❔

Makes node framework the only way to run main node.
Removes `initialize_components` function.

⚠️ Some leftovers are left in `core_leftovers` -- these are still used
in some places. Removing them will be tacked separately.

## Why ❔

Part of the migration.

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
- [ ] Spellcheck has been run via `zk spellcheck`.
  • Loading branch information
popzxc authored Jun 20, 2024
1 parent f851615 commit 0a38891
Show file tree
Hide file tree
Showing 9 changed files with 96 additions and 2,764 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-core-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ jobs:
# `sleep 5` because we need to wait until server started properly
- name: Run server
run: |
ci_run zk server --use-node-framework --components=$SERVER_COMPONENTS &>server.log &
ci_run zk server --components=$SERVER_COMPONENTS &>server.log &
ci_run sleep 5
- name: Run contract verifier
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-zk-toolbox-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ jobs:
- name: Run server
run: |
ci_run zk_inception server --ignore-prerequisites -a --use-node-framework --verbose &>server.log &
ci_run zk_inception server --ignore-prerequisites -a --verbose &>server.log &
ci_run sleep 5
- name: Run integration tests
Expand Down
183 changes: 0 additions & 183 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0a38891

Please sign in to comment.