Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localnet command #16

Merged
merged 28 commits into from
Sep 11, 2023
Merged

Add localnet command #16

merged 28 commits into from
Sep 11, 2023

Conversation

mationorato
Copy link
Contributor

Add the ability to handle a local node from the zksync-cli localnet command, abstracting the user from previous knowledge of using Docker.

Requires matter-labs/local-setup#8 to be merged first.

- `zksync-cli localnet stop`: stop L1 and L2 localnets.
- `zksync-cli localnet logs`: Display logs.
- `zksync-cli localnet help`: Display this message and quit.
- `zksync-cli localnet wallets`: Display seeded wallet keys.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/localnet.ts Outdated Show resolved Hide resolved
…rlabs-main

Fix merge conflicts with the matterlab's `main` branch.
mm-zk
mm-zk previously approved these changes Jul 25, 2023
@MexicanAce
Copy link
Collaborator

matter-labs/local-setup#8 is now merged

bin/index.js Outdated
@@ -0,0 +1,80 @@
#! /usr/bin/env node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the files in the bin/ directory from this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed @ c58b62b

@@ -1,12 +1,12 @@
{
"name": "zksync-cli",
"version": "0.1.4",
"version": "0.2.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revert these changes as we're moving to semantic-release

src/help.ts Outdated Show resolved Hide resolved
src/localnet.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jpcenteno jpcenteno requested a review from a team as a code owner September 4, 2023 17:20
@jpcenteno
Copy link
Contributor

All comments and merge conflicts were addressed. I tested it manually on my workstation and it works as intended.

@jpcenteno
Copy link
Contributor

I fixed the merge conflicts and adapted the PR to follow the new project structure introduced @ 632cb36 (Nice job refactoring the project BTW)

Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 44ce06e into matter-labs:main Sep 11, 2023
@github-actions
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants