Feat: localnet subcommand #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ilitteri
reviewed
May 4, 2023
src/localnet.ts
Outdated
Comment on lines
5
to
18
| /** | ||
| * Runs CLI commands | ||
| * @param {*} command String command to run | ||
| */ | ||
| const runCommand = (command: string) => { | ||
| try { | ||
| // runs given command and prints its output to console | ||
| execSync(`${command}`, { stdio: 'inherit' }); | ||
| } catch (error) { | ||
| console.error('Failed to run command: ', error); | ||
| return false; | ||
| } | ||
| return true; | ||
| }; |
There was a problem hiding this comment.
I saw that we have the same function in src/create.ts. Would it be a good idea to abstract it?
mationorato
reviewed
May 5, 2023
There was a problem hiding this comment.
what is this @jpcenteno ?
There was a problem hiding this comment.
I don't understand why I appear as a co-author of that commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1 #2