Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #55

Closed
wants to merge 4 commits into from
Closed

Conversation

xiaoxianBoy
Copy link
Contributor

@xiaoxianBoy xiaoxianBoy commented Mar 18, 2024

fix typos

  1. Fix bin/vault-unseal/src/main.rs typo
  2. Fix examples/README.md typo

@xiaoxianBoy xiaoxianBoy requested a review from a team as a code owner March 18, 2024 05:40
@haraldh
Copy link
Contributor

haraldh commented Mar 18, 2024

plz also correct the source:

bin/vault-unseal/src/main.rs:    info!("Inititalizing vault");

haraldh
haraldh previously approved these changes Mar 18, 2024
@haraldh
Copy link
Contributor

haraldh commented Mar 18, 2024

Ah, please gpg sign your commits

Copy link
Contributor

@haraldh haraldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 4 commits?

@xiaoxianBoy
Copy link
Contributor Author

why 4 commits?

add gpg😹

@haraldh
Copy link
Contributor

haraldh commented Mar 18, 2024

Please do the following to resign your original 2 commits:

$ git reset --hard HEAD~2
$ git rebase --gpg-sign HEAD~2

@xiaoxianBoy
Copy link
Contributor Author

Please do the following to resign your original 2 commits:

请执行以下操作以辞去您原来的2次提交:

$ git reset --hard HEAD~2
$ git rebase --gpg-sign HEAD~2

ths

@xiaoxianBoy xiaoxianBoy deleted the fixdevelop branch March 18, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants