Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing detect_missing_libraries arg #822

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

MBerguer
Copy link
Contributor

@MBerguer MBerguer commented Jan 9, 2025

What 💻

There are a couple of reasons for removing the arg:

  1. This has not worked as expected since we started working on the Solc linking because of (2).
  2. The missing libraries are always reported in another format on the output, and you can see them using --json (if any)
  3. This arg will be removed entirely in the following weeks when we move to version 1.5.8; see this for more info

Why ✋

See #722 (comment)

Documentation 📚

Please ensure the following before submitting your PR:

  • Check if these changes affect any documented features or workflows.
  • Update the book if these changes affect any documented features or workflows.

@MBerguer MBerguer requested a review from a team as a code owner January 9, 2025 03:13
@MBerguer MBerguer changed the title Detect Missing Libraries no more feat: Removing detect_missing_libraries arg Jan 9, 2025
@MBerguer
Copy link
Contributor Author

MBerguer commented Jan 9, 2025

Note: The PR that updates the book is here: matter-labs/foundry-zksync-book#62; once this is merged, we should proceed and merge that one, too

@MBerguer MBerguer merged commit 181e3ba into main Jan 9, 2025
23 of 24 checks passed
@MBerguer MBerguer deleted the tincho/feat/remove-detect-missing-libraries branch January 9, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants