feat: fix re-entrancy in strategies #801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Strategy
is split intoRunner
andContext
, which can be partially borrowed.Runner
implements all methods with immutable&self
and takes the&mut Context
to mutate.Context
is implemented viaAny
and is downcastable and specific to each implementation.self
parameter is passed into the strategy objects:&mut Context
may be omitted as it's available viaself.strategy.context
.self.strategy.runner
can be cloned and dissociated fromself
:self.strategy.runner.clone().foo(self)
.Why ✋
Evidence 📷
Tests pass