Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include anvil-zksync in foundryup install script #765

Merged
merged 13 commits into from
Dec 10, 2024
Merged

feat: include anvil-zksync in foundryup install script #765

merged 13 commits into from
Dec 10, 2024

Conversation

dutterbutter
Copy link
Collaborator

@dutterbutter dutterbutter commented Dec 3, 2024 •
edited
Loading

Pending release of: https://github.com/matter-labs/era-test-node/pull/444.

CI expected to fail until era_test_node renamed to anvil-zksync

To test:

  • checkout this branch
  • cd foundryup-zksync
  • ./foundryup-zksync

What 💻

  • include anvil-zksync in foundryup install script

Why ✋

  • allow users to make use of anvil-zksync

Evidence 📷

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@dutterbutter dutterbutter mentioned this pull request Dec 3, 2024
Merged
popzxc
popzxc previously approved these changes Dec 4, 2024
View reviewed changes
@dutterbutter dutterbutter marked this pull request as ready for review December 4, 2024 14:47
@dutterbutter dutterbutter requested a review from a team as a code owner December 4, 2024 14:47
@dutterbutter dutterbutter requested a review from popzxc December 4, 2024 15:56
Karrq
Karrq reviewed Dec 4, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
foundryup-zksync/foundryup-zksync Outdated Show resolved Hide resolved
@dutterbutter dutterbutter requested a review from Karrq December 4, 2024 16:12
@dutterbutter dutterbutter added the do not merge 🛑 Do not merge this PR until label is removed label Dec 5, 2024
@dutterbutter dutterbutter mentioned this pull request Dec 5, 2024
Merged
@popzxc
Copy link
Member

popzxc commented Dec 9, 2024

@dutterbutter is it time to hit the merge button? :)

@dutterbutter dutterbutter added needs review 👓 PR requires a review and removed do not merge 🛑 Do not merge this PR until label is removed labels Dec 9, 2024
@dutterbutter dutterbutter requested a review from Karrq December 9, 2024 15:05
@dutterbutter
Copy link
Collaborator Author

@popzxc could you review please

@dutterbutter dutterbutter requested review from Karrq and removed request for Karrq December 10, 2024 14:02
@dutterbutter dutterbutter merged commit f6527ae into main Dec 10, 2024
5 checks passed
@dutterbutter dutterbutter deleted the db/update-install-script-to-include-anvil-zksync branch December 10, 2024 14:54
@dutterbutter dutterbutter mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@Romsters Romsters Romsters approved these changes

@nbaztec nbaztec nbaztec approved these changes

@Karrq Karrq Awaiting requested review from Karrq

Assignees
No one assigned
Labels
needs review 👓 PR requires a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dutterbutter @popzxc @nbaztec @Karrq @Romsters