chore: explicit behavior for nonce update persistence #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfedy
reviewed
Nov 16, 2024
Karrq
reviewed
Nov 18, 2024
| } | ||
|
|
||
| /// Retrieve if a nonce update must be persisted, or not. Resets the state to default. | ||
| pub fn get(&mut self) -> bool { |
There was a problem hiding this comment.
I'd actually rename this a bit to be slightly more explicit. I mean the &mut still indicates that we will mutate it but I believe a more descriptive name would be better...
Maybe read_and_reset or get_and_clear
|
@Jrigada can you review this please? |
…ix-nonce-mismatch-scripts
Jrigada
added a commit
that referenced
this pull request
Nov 21, 2024
* Nonce mismatch on setup with script * Add toggle to update nonce only on first operation to avoid nonce mismatch with the network * Remove prints and format test * Update crates/cheatcodes/src/inspector.rs Co-authored-by: Federico Rodríguez <[email protected]> * Update crates/cheatcodes/src/inspector.rs Co-authored-by: Federico Rodríguez <[email protected]> * Update crates/forge/tests/fixtures/zk/ScriptSetup.s.sol Co-authored-by: Federico Rodríguez <[email protected]> * Update crates/cheatcodes/src/inspector.rs Co-authored-by: Federico Rodríguez <[email protected]> * change variable and test name * Change test name of noncemismatch * Add description, filter before iteration for loop and take() in cheatcode context creation * Remove taking in inspector of zk should update nonce * chore: explicit behavior for nonce update persistence (#729) * explicit behavior for nonce update persistence * prevent short-circuit bug * enable persistance only once per test contract deployment * Format and change test * Forge fmt * improve comments * Add comment to test --------- Co-authored-by: Federico Rodríguez <[email protected]> Co-authored-by: Nisheeth Barthwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻