fix: Add check in ZK create to check if it's the test contract #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
previously approved these changes
Sep 20, 2024
nbaztec
reviewed
Sep 20, 2024
Co-authored-by: Nisheeth Barthwal <[email protected]>
Karrq
reviewed
Sep 20, 2024
Karrq
reviewed
Sep 20, 2024
nbaztec
approved these changes
Sep 20, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The motivation of this PR is to solve the issue 579 that raised that a script that was meant to fail was not when not passing an rpc-url or fork-url
Solution
Check wether we are dealing with the test contract to avoid deploying it in Zk-vm and later try to execute in EVM.