Update local node instruction link in README.md #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tamer Tas <tmrtx@noreply>
* zk_utils comment * update developer comments for zkutils and zksolc * update doc * Update README.md * Update README.md
Better error handling for failed transactions
Added support for Macs with Apple Silicon: selecting proper zksync compiler information on where to get the most recent solidity
* added better compiler error passing and support for version 1.3.10 * added comments * more instructions * more info
We're currently based off the old fork of foundry, that was depending on the old version of ethers-rs, which supported the solc compiler only up to 0.8.17 (especially on Apple Silicon). With this PR, I'm moving us to depend on a fork of ethers-rs, that has svm (solidity version manager) patched to the newest release - therefore allowing us to support 0.8.20. In the near future, we'll rebase ourselves to newer version of foundry, and this dependency would be switched back to original ethers repo.
Fix flags used by zk-deposit: Use --l1-url and --l2-url (and ignore the --rpc-url flag)
Edited README
* WIP deposit using zksync_ethers_rs * WIP deposit and test script * Add zksync rust sdk as dependency * Use withdraw from Rust SDK * Add to address as parameter for withdraw * WIP test * Add support for multiple flags in withdraw * Update cargo.lock * Use Rust SDK to send transactions to contracts * Fix deposit test * Support all parameter types for send command * Add optional fields to deposit * Add missing deposit parameters * Cleanup * wip. * Deploy with constructor parameters * Remove unwraps and commented code * Fix operator_tip setter * Remove legacy test script * point zksync-web3-rs to main * revert cargo.toml autoformat * Fix create. * Remove zksync dependencies. * Update deploy with new signature from Rust SDK * Add support for construction parameters from file. * Update function to get constructor arguments * Add back chain id to every zk function. * Minor cleanups and consistency. (#9) * Add transaction id to print after deploy * Fix compiler warnings * Update zksync-web3-rs commit in dependencies * Add necessary changes with new SDK version --------- Co-authored-by: Joaquín P. Centeno <[email protected]> Co-authored-by: IAvecilla <[email protected]> Co-authored-by: Matías Onorato <[email protected]>
In the README there is a link to the instructions to setup to local Docker node. The current link is broken, and this PR updates to the correct one.
|
Closing in favour of #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the README there is a link to the instructions to setup to local Docker node. The current link is broken, and this PR updates to the correct one.
The broken link now resolves to a page about Hardhat plugins (https://era.zksync.io/docs/tools/hardhat/).