Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: ZkUseFactoryDep cheatcode documentation #45

Merged
merged 2 commits into from
Oct 31, 2024
Merged

docs: ZkUseFactoryDep cheatcode documentation #45

merged 2 commits into from
Oct 31, 2024

Conversation

Jrigada
Copy link
Collaborator

@Jrigada Jrigada commented Oct 30, 2024 •
edited
Loading

  • New page explaining the usage of the new cheatcode ZkUseFactoryDep
  • Example of a multisig smart account deployment using ZkUseFactoryDep

Addresses #44

@Jrigada Jrigada marked this pull request as ready for review October 30, 2024 18:21
@Jrigada Jrigada requested review from tomimor, nbaztec and Karrq October 30, 2024 18:21
nbaztec
nbaztec previously approved these changes Oct 30, 2024
View reviewed changes
Karrq
Karrq requested changes Oct 31, 2024
View reviewed changes
src/zksync-specifics/cheatcodes/zk-use-factory-dep.md Outdated Show resolved Hide resolved
src/zksync-specifics/cheatcodes/zk-use-factory-dep.md Outdated Show resolved Hide resolved
src/zksync-specifics/examples/smart-account.md Outdated Show resolved Hide resolved
src/zksync-specifics/examples/smart-account.md Outdated Show resolved Hide resolved
src/zksync-specifics/cheatcodes/zk-use-factory-dep.md Show resolved Hide resolved
src/zksync-specifics/examples/smart-account.md Outdated Show resolved Hide resolved
@tomimor tomimor added the documentation Improvements or additions to documentation label Oct 31, 2024
@Jrigada Jrigada requested a review from Karrq October 31, 2024 15:22
tomimor
tomimor reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@tomimor tomimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Karrq Karrq linked an issue Oct 31, 2024 that may be closed by this pull request
Add documentation of ZkUseFactoryDep new cheatcode to foundry book #44
Closed
@Jrigada Jrigada merged commit efe54da into main Oct 31, 2024
3 checks passed
@Jrigada Jrigada deleted the feat-jrigada-smart-account-docs branch October 31, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomimor tomimor tomimor left review comments

@Karrq Karrq Karrq approved these changes

@nbaztec nbaztec nbaztec left review comments

Assignees

@Jrigada Jrigada

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation of ZkUseFactoryDep new cheatcode to foundry book
4 participants
@Jrigada @nbaztec @Karrq @tomimor