Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for forge verify-check via zksync verifier #35

Merged
merged 3 commits into from
Oct 24, 2024
Merged

feat: adds support for forge verify-check via zksync verifier #35

merged 3 commits into from
Oct 24, 2024

Conversation

dutterbutter
Copy link

Changes introduced in this PR:

  • Adds support check to verify-check

Karrq
Karrq reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Karrq Karrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to specify which explorers are supported and/or what are the unsupported features

@dutterbutter
Copy link
Author

@Karrq I've updated to mention you must use --verifier with ZKsync block explorer and also support for Etherscan is mentioned.

@dutterbutter dutterbutter requested a review from Karrq October 23, 2024 14:57
@dutterbutter dutterbutter merged commit 8f64c2e into main Oct 24, 2024
3 checks passed
@dutterbutter dutterbutter deleted the db/update-verify-checks branch October 24, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karrq Karrq Karrq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dutterbutter @Karrq