feat: Conditionally enable EVM emulation

[slowli]

What 💻

• Updates zksync-era dependencies. Remove zksync_state and zksync_node_fee_model deps as unnecessary.
• Conditionally enables EVM emulation using --emulate-evm flag. For now, this requires local contracts with EVM emulation support.

Why ✋

• Local node can assist with EVM emulator development.

Evidence 📷

• CI tests pass.
• Tested locally.

[slowli]

@mm-zk Rust cache in CI looks broken; is this a known issue? It could be related to bumping the commit for the zksync-era deps; as you can see from this CI run, one job for which I've manually disabled caching works fine, and the other ones fail with esoteric errors ("can't find crate"). Weirdly enough, CI worked fine at first, and the "run" jobs that use the same caching approach work fine as well.

[0xVolosnikov]

LGTM, but I propose to update it after this PR: matter-labs/zksync-era#3127

[popzxc]

@dutterbutter could you PTAL?

[dutterbutter]

LGTM !

[0xVolosnikov]

Have you tried running this with a EVM emulator?

[dutterbutter]

@0xVolosnikov Yes. Well perhaps I will be more specific on the steps I used to test.

• Tried with the following contracts branch https://github.com/matter-labs/era-contracts/tree/stable/evm-emulator

To reproduce:

• cd contracts
• git checkout 8bc5e7a2aee82490e107668e400fe0ae9831d625
• cd ..
• cargo build --release

Command to start era-test-node:

./target/release/era_test_node --dev-system-contracts=local --emulate-evm run

Tested forge usage by running the following:

• forge init testing_evm
• cd testing_evm
• forge script script/Counter.s.sol:CounterScript --rpc-url http://127.0.0.1:8011 --broadcast --sender 0x87d6ab9fE5Adef46228fB490810f0F5CB16D6d04 --private-key <ERA-TEST-NODE-RICH-WALLETS> -vvvv --zksync

Note: I was still required to make use of --zksync flag.

[0xVolosnikov]

Can't deploy EVM bytecode: must have recipient address

[dutterbutter]

Apologies I did not go deeper in initial review testing as with --zksync flag things worked as expected but its apparent that they should be working without --zksync flag.

@slowli you need to adjust the DebugCall's to field usage in src/utils.rs. If evm emulator is used it does not need to be known.

I was able to successfully use forge create with below change:

Deployer: 0x78cAD996530109838eb016619f5931a03250489A
Deployed to: 0x6d6964656d480bAADA75790519f171fCd1dd3956
Transaction hash: 0xdf38929ee34dde84a30abf305410f855cec5ded64b78024a09279b784f027589

In src/utils.rs update to field with unwrap_or_default() and unwrap() - see below:

          ExecutionResult::Success { output } => Ok(DebugCall {
            gas_used: result.statistics.gas_used.into(),
            output: output.clone().into(),
            r#type: calltype,
            from: l2_tx.initiator_account(),
            to: l2_tx.recipient_account().unwrap_or_default(),
            gas: l2_tx.common_data.fee.gas_limit,
            value: l2_tx.execute.value,
            input: l2_tx.execute.calldata().into(),
            error: None,
            revert_reason: None,
            calls: traces.into_iter().map(call_to_debug_call).collect(),
        }),
        ExecutionResult::Revert { output } => Ok(DebugCall {
            gas_used: result.statistics.gas_used.into(),
            output: Default::default(),
            r#type: calltype,
            from: l2_tx.initiator_account(),
            to: l2_tx.recipient_account().unwrap(),
            gas: l2_tx.common_data.fee.gas_limit,
            value: l2_tx.execute.value,
            input: l2_tx.execute.calldata().into(),
            error: None,
            revert_reason: Some(output.to_string()),
            calls: traces.into_iter().map(call_to_debug_call).collect(),
        }),

Inaccurate testing assumptions used.

[slowli]

JFYI, as I've mentioned in comments above, I've been able to deploy a test forge Counter contract successfully with forge script (although it requires specifying an insane gas multiplier – order of 500x; caused by not using eth_estimateGas and not accounting for large amount of pubdata produced by the transaction), and using forge create (this one does use eth_estimateGas, so it works out of the box).