-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add logs for incoming API requests #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I like this with the info
level tbh. Could get quite noisy with more complicated deployments. Perhaps this is better suited for a trace
level that can be introduced?
@MexicanAce please address conflicts |
Discussed offline and added the Ultimately, we want to discover the most useful default console output for |
What 💻
not_implemented
logs to warningsWhy ✋
eth_feeHistory
Evidence 📷
Example of new
not_implemented
logs:Output of
make test-e2e
with default logs:Output of
eth_getBlockByNumber
withtrace
log level:Notes 📝
LevelFilter
in the middleware because I wanted to avoid duplicate log statements fortrace
andinfo
. Theinfo
is meant to be truncated/short/concise, while trace log can be MASSIVE depending on the incoming payload.