Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add eth_getBlockTransactionCountByHash and eth_getBlockTransactionCountByNumber #117

Merged
merged 6 commits into from
Sep 18, 2023
Merged

feat: Add eth_getBlockTransactionCountByHash and eth_getBlockTransactionCountByNumber #117

merged 6 commits into from
Sep 18, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Sep 14, 2023 •
edited
Loading

What 💻

  • Adds support for eth_getBlockTransactionCountByHash
  • Adds support for eth_getBlockTransactionCountByNumber
  • Improves testing server

Why ✋

  • Users might need to view the number of transactions contained in a block by its hash or by the number.
  • It is beneficial to generate raw json for blocks and transactions instead of the response object during testing as many objects are composable.

Evidence 📷

image

Notes 📝

MexicanAce
MexicanAce previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left 1 suggestion

src/node.rs Outdated Show resolved Hide resolved
src/node.rs Outdated Show resolved Hide resolved
@nbaztec nbaztec marked this pull request as ready for review September 18, 2023 09:53
@nbaztec nbaztec requested a review from a team as a code owner September 18, 2023 09:53
MexicanAce
MexicanAce approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 35ac2c7 into matter-labs:main Sep 18, 2023
8 checks passed
IAvecilla added a commit to lambdaclass/era-test-node that referenced this pull request Feb 29, 2024
@IAvecilla
Make modexp consistent with the other precompiles (matter-labs#117)
637ea8e 
* Delete constants for zero, one and use literals

* Remove log for debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nbaztec @MexicanAce