Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl eth_syncing #104

Merged
merged 7 commits into from
Sep 7, 2023
Merged

feat: impl eth_syncing #104

merged 7 commits into from
Sep 7, 2023

Conversation

grw-ms
Copy link
Contributor

@grw-ms grw-ms commented Sep 7, 2023

What 💻

  • Adds trivial eth_syncing handler, which returns false (as does anvil and hardhat)

Why ✋

  • Compatibility with existing sdks

Evidence 📷

image

Notes 📝

@dutterbutter
Copy link
Collaborator

@grw-ms thanks for the contribution! Can you address the conflicts on this PR please.

@grw-ms
Copy link
Contributor Author

grw-ms commented Sep 7, 2023

@grw-ms thanks for the contribution! Can you address the conflicts on this PR please.

done

dutterbutter
dutterbutter approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dutterbutter dutterbutter added the approved ✅ PR is ready to be merged label Sep 7, 2023
@dutterbutter dutterbutter merged commit fee3152 into matter-labs:main Sep 7, 2023
7 checks passed
@grw-ms grw-ms deleted the grw/impl-eth-syncing branch September 7, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

@MexicanAce MexicanAce Awaiting requested review from MexicanAce

@uF4No uF4No Awaiting requested review from uF4No

@mm-zk mm-zk Awaiting requested review from mm-zk

Assignees
No one assigned
Labels
approved ✅ PR is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_api: Implement syncing method
2 participants
@grw-ms @dutterbutter