Draft: updated fee model #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanislavBreadless
changed the base branch from
dev
to
sb-reinitialize-erc20-token
Base automatically changed from
sb-reinitialize-erc20-token
to
v1-4-1-integration
November 28, 2023 15:11
0xemagic
reviewed
Dec 1, 2023
Comment on lines
+21
to
+23
| /// @param verifier address of Verifier contract | ||
| /// @param governor address who can manage critical updates in the contract | ||
| /// @param admin address who can manage non-critical updates in the contract |
There was a problem hiding this comment.
Suggested change
| /// @param verifier address of Verifier contract | |
| /// @param governor address who can manage critical updates in the contract | |
| /// @param admin address who can manage non-critical updates in the contract | |
| /// @param verifier Address of Verifier contract | |
| /// @param governor Address who can manage critical updates in the contract | |
| /// @param admin Address who can manage non-critical updates in the contract |
0xemagic
reviewed
Dec 1, 2023
Comment on lines
+31
to
+32
| /// @param priorityTxMaxGasLimit maximum number of the L2 gas that a user can request for L1 -> L2 transactions | ||
| /// @param initialProtocolVersion initial protocol version |
There was a problem hiding this comment.
Suggested change
| /// @param priorityTxMaxGasLimit maximum number of the L2 gas that a user can request for L1 -> L2 transactions | |
| /// @param initialProtocolVersion initial protocol version | |
| /// @param priorityTxMaxGasLimit Maximum number of the L2 gas that a user can request for L1 -> L2 transactions | |
| /// @param initialProtocolVersion Initial protocol version |
AntonD3
reviewed
Jan 5, 2024
|
|
||
| // Ensuring that the transaction is provable | ||
| require(l2GasForTxBody <= _priorityTxMaxGasLimit, "ui"); | ||
| // Ensuring that the transaction cannot output more pubdata than is processable | ||
| require(l2GasForTxBody / _transaction.gasPerPubdataByteLimit <= PRIORITY_TX_MAX_PUBDATA, "uk"); | ||
| require(l2GasForTxBody / _transaction.gasPerPubdataByteLimit <= _priorityTxMaxPubdata, "uk"); |
There was a problem hiding this comment.
Do you think it makes to add a comment that we intentionally don't check that the tx encoding length is less than the maximal allowed? (As I understand it's just impossible to exceed this limit, due to gas limitations on l1)
Port 1 4 1 fixes to the short term fee model
…ation Make upgrade validation more strict
Add security contact
Use more clear visibility for variables and constants
Better docs for L2Weth
Named mapping variables
Fix documentation mismatch
|
The content of this PR has been included into the following release: #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist