use chain admin for bridgehub manipulations #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <[email protected]>
Deniallugo
force-pushed
the
deniallugo-use-chain-admin-for-bridgehub
branch
from
021f02f to
0f26ff8
Compare
vladbochok
reviewed
Sep 12, 2024
vladbochok
reviewed
Sep 12, 2024
|
|
||
| StateTransitionManager stm = StateTransitionManager(addresses.stateTransition.stateTransitionProxy); | ||
| stm.transferOwnership(addresses.governance); | ||
| stm.setPendingAdmin(addresses.chainAdmin); |
There was a problem hiding this comment.
should you also accept ownership?
There was a problem hiding this comment.
Since it's a script from one private key, i can't accept it right here i do it in the zk_toolbox
There was a problem hiding this comment.
this is the counterpart matter-labs/zksync-era#2857
Signed-off-by: Danil <[email protected]>
Deniallugo
force-pushed
the
deniallugo-use-chain-admin-for-bridgehub
branch
from
0f26ff8 to
8f3cf75
Compare
vladbochok
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Why ❔
Checklist