Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge stable #785

Merged
merged 4 commits into from
Sep 10, 2024
Merged

chore: merge stable #785

merged 4 commits into from
Sep 10, 2024

Conversation

kelemeno
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

github-actions bot commented Sep 10, 2024

Changes to gas cost

Generated at commit: 7dc51662b0033fc17dd7026651f35a684d8e5822, compared to commit: cb42ae402af3e3f676003f44a49da4ea37a6811c

🧾 Summary (100% most significant diffs)

Contract Method Avg (+/-) %
L1NativeTokenVault bridgeBurn
bridgeMint
bridgeRecoverFailedTransfer
chainBalance
initialize
tokenAddress
transferFundsFromSharedBridge
updateChainBalancesFromSharedBridge
+10,908 ❌
+4,095 ❌
-6 ✅
-70 ✅
+65,695 ❌
-44 ✅
+157 ❌
+277 ❌
+31.32%
+11.64%
-0.02%
-6.48%
+131.58%
-1.73%
+0.73%
+1.11%
L1AssetRouter bridgeRecoverFailedTransfer
bridgehubConfirmL2Transaction
bridgehubDeposit
bridgehubDepositBaseToken
depositLegacyErc20Bridge
finalizeWithdrawal
initialize
setAssetHandlerAddressThisChain
setL1Erc20Bridge
setNativeTokenVault
unpause
-2,457 ✅
+14,654 ❌
+5,038 ❌
-1,652 ✅
+19,434 ❌
+22,047 ❌
-67,734 ✅
-236 ✅
-45 ✅
+21,919 ❌
-1 ✅
-5.10%
+75.04%
+8.48%
-2.78%
+17.50%
+32.96%
-48.45%
-0.48%
-0.19%
+90.35%
-0.01%
TransparentUpgradeableProxy bridgeRecoverFailedTransfer
bridgehubConfirmL2Transaction
bridgehubDeposit
bridgehubDepositBaseToken
chainBalance
claimFailedDeposit
createNewChain
depositHappened
depositLegacyErc20Bridge
encodeTxDataHash
finalizeWithdrawal
getHyperchain
legacyBridge
nativeTokenVault
nullifyChainBalanceByNTV
paused
registerToken
setChainCreationParams
setL1Erc20Bridge
setNativeTokenVault
setNewVersionUpgrade
setUpgradeDiamondCut
transferFundsFromSharedBridge
transferTokenToNTV
unpause
updateChainBalancesFromSharedBridge
+9,188 ❌
+14,654 ❌
+5,039 ❌
+892 ❌
-87 ✅
+11,432 ❌
+23 ❌
-66 ✅
+19,434 ❌
-1,944 ✅
+22,109 ❌
+22 ❌
-12 ✅
-12 ✅
-22 ✅
+22 ❌
+22,769 ❌
+12 ❌
+244 ❌
+21,908 ❌
+12 ❌
+12 ❌
+157 ❌
-50 ✅
-1 ✅
+277 ❌
+12.00%
+30.08%
+5.84%
+1.07%
-4.91%
+15.13%
+0.03%
-2.20%
+14.68%
-35.66%
+23.65%
+0.47%
-0.27%
-0.39%
-0.07%
+2.28%
+20.45%
+0.01%
+0.46%
+41.51%
+0.01%
+0.01%
+0.32%
-0.16%
-0.00%
+0.57%
GettersFacetWrapper util_setFirstUnprocessedPriorityTx
util_setIsDiamondStorageFrozen
util_setL2SystemContractsUpgradeTxHash
util_setValidator
-44 ✅
+22 ❌
+22 ❌
+22 ❌
-0.10%
+0.05%
+0.05%
+0.06%
TestExecutor commitBatchesSharedBridge
executeBatchesSharedBridge
proveBatchesSharedBridge
setPriorityTreeStartIndex
+2,533 ❌
-226 ✅
-198 ✅
-22 ✅
+9.03%
-2.82%
-2.47%
-0.10%
MerkleTest calculateRoot(bytes32[],bytes32[],uint256,bytes32[])
calculateRoot(bytes32[],uint256,bytes32)
+419 ❌
+1 ❌
+7.89%
+0.03%
L1ERC20Bridge claimFailedDeposit
deposit(address,address,uint256,uint256,uint256)
deposit(address,address,uint256,uint256,uint256,address)
depositAmount
finalizeWithdrawal
initialize
isWithdrawalFinalized
l2TokenAddress
-36 ✅
+20 ❌
+43 ❌
+8 ❌
+1,985 ❌
+66 ❌
+22 ❌
+6 ❌
-0.09%
+0.03%
+0.06%
+0.63%
+5.61%
+0.28%
+1.95%
+0.49%
DiamondProxy executeBatchesSharedBridge
finalizeEthWithdrawal
getAdmin
getChainId
getPriorityTreeRoot
proveBatchesSharedBridge
requestL2Transaction
setPriorityTreeStartIndex
+493 ❌
-219 ✅
+22 ❌
+22 ❌
+22 ❌
+82 ❌
-730 ✅
-22 ✅
+1.24%
-0.29%
+0.43%
+0.24%
+0.33%
+0.19%
-0.56%
-0.04%
ValidatorTimelock addValidator
commitBatchesSharedBridge
executeBatchesSharedBridge
getCommittedBatchTimestamp
proveBatchesSharedBridge
removeValidator
revertBatchesSharedBridge
setChainTypeManager
validators
-22 ✅
+326 ❌
+330 ❌
-22 ✅
+72 ❌
+44 ❌
-30 ✅
-22 ✅
+44 ❌
-0.04%
+0.57%
+1.01%
-1.34%
+0.22%
+0.14%
-0.11%
-0.05%
+2.65%
VerifierTest verificationKeyHash
verify
-33 ✅
-245 ✅
-3.20%
-0.18%
VerifierRecursiveTest verificationKeyHash
verify
-33 ✅
-248 ✅
-3.20%
-0.18%
DummyBridgehubSetter acceptOwnership
addTokenAssetId
chainTypeManager
initialize
setCTM
setPendingAdmin
setZKChain
+67 ❌
-22 ✅
-22 ✅
+22 ❌
+47 ❌
-26 ✅
+2 ❌
+0.26%
-0.06%
-1.07%
+0.09%
+0.11%
-0.06%
+0.00%
Utils constructRollupL2DAValidatorOutputHash
createCommitBatchInfo
getExecutorSelectors
getGettersSelectors
getMailboxSelectors
makeInitializeDataForNewChain
randomBytes32
-22 ✅
-22 ✅
-22 ✅
-22 ✅
+44 ❌
+45 ❌
-22 ✅
-1.58%
-0.53%
-1.79%
-0.35%
+2.49%
+2.24%
-2.02%
PriorityTreeTest initFromCommitment
processBatch
push
-17 ✅
+826 ❌
-1 ✅
-0.03%
+2.26%
-0.00%
ChainTypeManager createNewChain
getHyperchain
+40 ❌
+22 ❌
+0.00%
+1.39%
GettersFacet getChainId
getPriorityTreeRoot
+22 ❌
+22 ❌
+0.93%
+0.80%
Bridgehub createNewChain
getZKChain
l1CtmDeployer
setAddresses
+117 ❌
+22 ❌
+22 ❌
-22 ✅
+0.00%
+0.76%
+0.93%
-0.03%
ChainAdmin multicall
setUpgradeTimestamp
0 ➖
-396 ✅
0.00%
-0.87%
MailboxFacet finalizeEthWithdrawal
requestL2Transaction
-238 ✅
-727 ✅
-0.48%
-0.73%
TestnetERC20Token approve
mint
+119 ❌
-280 ✅
+0.26%
-0.53%
PermanentRestriction setAllowedData
validateCall
-25 ✅
+66 ❌
-0.05%
+0.23%
GenerateForceDeploymentsData run -77 ✅ -0.04%
DiamondCutTestContract diamondCut +2 ❌ +0.00%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
L1NativeTokenVault 3,702,940 (+1,234,308) bridgeBurn
bridgeMint
bridgeRecoverFailedTransfer
chainBalance
initialize
receive
registerToken
tokenAddress
transferFundsFromSharedBridge
updateChainBalancesFromSharedBridge
10,016 (+4,773)
9,590 (+2,220)
5,217 (0)
565 (-70)
23,155 (+68)
109 (+26)
435 (0)
2,495 (-44)
8,875 (+65)
25,266 (+277)
+91.04%
+30.12%
0.00%
-11.02%
+0.29%
+31.33%
0.00%
-1.73%
+0.74%
+1.11%
45,741 (+10,908)
39,266 (+4,095)
30,956 (-6)
1,010 (-70)
115,623 (+65,695)
109 (+26)
101,893 (+21,596)
2,495 (-44)
21,581 (+157)
25,266 (+277)
+31.32%
+11.64%
-0.02%
-6.48%
+131.58%
+31.33%
+26.90%
-1.73%
+0.73%
+1.11%
44,455 (+15,673)
33,646 (+4,411)
36,169 (-6)
565 (-70)
116,890 (+66,594)
109 (+26)
107,006 (+24,840)
2,495 (-44)
20,624 (+202)
25,266 (+277)
+54.45%
+15.09%
-0.02%
-11.02%
+132.40%
+31.33%
+30.23%
-1.73%
+0.99%
+1.11%
79,932 (+9,226)
51,480 (+4,399)
45,192 (-12)
2,565 (-70)
116,890 (+66,594)
109 (+26)
107,006 (+22,224)
2,495 (-44)
33,302 (+156)
25,266 (+277)
+13.05%
+9.34%
-0.03%
-2.66%
+132.40%
+31.33%
+26.21%
-1.73%
+0.47%
+1.11%
17 (0)
14 (0)
8 (0)
673 (0)
74 (0)
2 (0)
93 (-90)
1 (0)
5 (0)
2 (0)
L1AssetRouter 4,128,072 (-1,143,242) bridgeRecoverFailedTransfer
bridgehubConfirmL2Transaction
bridgehubDeposit
bridgehubDepositBaseToken
depositLegacyErc20Bridge
finalizeWithdrawal
initialize
legacyBridge
nativeTokenVault
paused
setAssetHandlerAddressThisChain
setL1Erc20Bridge
setNativeTokenVault
unpause
16,524 (+2,448)
19,498 (+14,652)
17,378 (+7,452)
520 (-22)
10,088 (-22)
28,150 (+17,600)
45,226 (-94)
379 (-12)
357 (-12)
393 (+22)
7,604 (+44)
4,664 (-45)
4,697 (-40)
8,615 (-1)
+17.39%
+302.35%
+75.08%
-4.06%
-0.22%
+166.82%
-0.21%
-3.07%
-3.25%
+5.93%
+0.58%
-0.96%
-0.84%
-0.01%
45,688 (-2,457)
34,181 (+14,654)
64,421 (+5,038)
57,755 (-1,652)
130,483 (+19,434)
88,928 (+22,047)
72,066 (-67,734)
1,179 (-12)
857 (-12)
393 (+22)
48,839 (-236)
24,236 (-45)
46,178 (+21,919)
8,615 (-1)
-5.10%
+75.04%
+8.48%
-2.78%
+17.50%
+32.96%
-48.45%
-1.01%
-1.38%
+5.93%
-0.48%
-0.19%
+90.35%
-0.01%
50,350 (+2,985)
41,523 (+14,655)
66,893 (+5,398)
55,152 (+4,103)
190,649 (+29,162)
108,476 (+24,611)
72,434 (-68,661)
379 (-12)
357 (-12)
393 (+22)
49,404 (+44)
24,771 (-45)
47,315 (+22,521)
8,615 (-1)
+6.30%
+54.54%
+8.78%
+8.04%
+18.06%
+29.35%
-48.66%
-3.07%
-3.25%
+5.93%
+0.09%
-0.18%
+90.83%
-0.01%
65,764 (-18,010)
41,523 (+14,655)
109,062 (+3,919)
87,642 (-32,774)
190,714 (+29,162)
126,310 (+24,589)
72,434 (-68,661)
2,379 (-12)
2,357 (-12)
393 (+22)
49,404 (+44)
24,771 (-45)
47,315 (+22,521)
8,615 (-1)
-21.50%
+54.54%
+3.73%
-27.22%
+18.05%
+24.17%
-48.66%
-0.50%
-0.51%
+5.93%
+0.09%
-0.18%
+90.83%
-0.01%
8 (+4)
3 (0)
10 (0)
8 (0)
3 (0)
19 (0)
74 (0)
5 (0)
4 (0)
3 (0)
74 (-73)
75 (0)
75 (0)
1 (0)
TransparentUpgradeableProxy 987,816 (+12) bridgeRecoverFailedTransfer
bridgehubConfirmL2Transaction
bridgehubDeposit
bridgehubDepositBaseToken
chainBalance
claimFailedDeposit
createNewChain
depositHappened
depositLegacyErc20Bridge
encodeTxDataHash
finalizeWithdrawal
getHyperchain
legacyBridge
nativeTokenVault
nullifyChainBalanceByNTV
paused
registerToken
setChainCreationParams
setL1Erc20Bridge
setNativeTokenVault
setNewVersionUpgrade
setUpgradeDiamondCut
tokenAddress
transferFundsFromSharedBridge
transferTokenToNTV
unpause
updateChainBalancesFromSharedBridge
45,479 (-103)
48,687 (+14,652)
46,892 (+7,452)
29,858 (-22)
1,163 (-70)
45,077 (+5,368)
55,516 (+12)
1,173 (-66)
39,720 (-22)
2,508 (-52)
58,785 (+17,600)
4,701 (+22)
971 (-12)
949 (-12)
31,315 (-22)
985 (+22)
28,893 (-34)
96,005 (+12)
32,952 (-45)
32,997 (-46)
200,413 (+12)
96,788 (+12)
0 (0)
37,415 (+65)
31,095 (-50)
31,968 (-1)
48,905 (+277)
-0.23%
+43.05%
+18.89%
-0.07%
-5.68%
+13.52%
+0.02%
-5.33%
-0.06%
-2.03%
+42.73%
+0.47%
-1.22%
-1.25%
-0.07%
+2.28%
-0.12%
+0.01%
-0.14%
-0.14%
+0.01%
+0.01%
+∞%
+0.17%
-0.16%
-0.00%
+0.57%
85,742 (+9,188)
63,367 (+14,654)
91,271 (+5,039)
84,088 (+892)
1,686 (-87)
86,996 (+11,432)
69,677 (+23)
2,937 (-66)
151,850 (+19,434)
3,508 (-1,944)
115,574 (+22,109)
4,701 (+22)
4,371 (-12)
3,074 (-12)
31,315 (-22)
985 (+22)
134,088 (+22,769)
96,005 (+12)
53,043 (+244)
74,685 (+21,908)
200,413 (+12)
96,788 (+12)
61 (-127)
49,061 (+157)
31,095 (-50)
31,968 (-1)
49,019 (+277)
+12.00%
+30.08%
+5.84%
+1.07%
-4.91%
+15.13%
+0.03%
-2.20%
+14.68%
-35.66%
+23.65%
+0.47%
-0.27%
-0.39%
-0.07%
+2.28%
+20.45%
+0.01%
+0.46%
+41.51%
+0.01%
+0.01%
-67.55%
+0.32%
-0.16%
-0.00%
+0.57%
82,687 (+8,367)
70,708 (+14,655)
96,599 (+5,398)
84,485 (+4,103)
1,163 (-103)
91,691 (+14,284)
69,677 (+23)
1,173 (-66)
207,877 (+29,162)
2,508 (-4,552)
131,943 (+24,757)
4,701 (+22)
971 (-12)
949 (-12)
31,315 (-22)
985 (+22)
135,530 (+25,068)
96,005 (+12)
53,295 (-45)
75,827 (+22,509)
200,413 (+12)
96,788 (+12)
0 (0)
48,920 (+202)
31,095 (-50)
31,968 (-1)
49,019 (+277)
+11.26%
+26.14%
+5.92%
+5.10%
-8.14%
+18.45%
+0.03%
-5.33%
+16.32%
-64.48%
+23.10%
+0.47%
-1.22%
-1.25%
-0.07%
+2.28%
+22.69%
+0.01%
-0.08%
+42.22%
+0.01%
+0.01%
+∞%
+0.41%
-0.16%
-0.00%
+0.57%
132,115 (+20,122)
70,708 (+14,655)
129,376 (+3,926)
112,173 (-7,625)
9,663 (-103)
115,788 (+13,987)
83,838 (+34)
9,673 (-66)
207,954 (+29,162)
7,008 (-52)
149,777 (+24,735)
4,701 (+22)
9,471 (-12)
9,449 (-12)
31,315 (-22)
985 (+22)
135,530 (+22,224)
96,005 (+12)
53,340 (0)
75,827 (+22,509)
200,413 (+12)
96,788 (+12)
3,090 (-6,544)
59,697 (+156)
31,095 (-50)
31,968 (-1)
49,133 (+277)
+17.97%
+26.14%
+3.13%
-6.36%
-1.05%
+13.74%
+0.04%
-0.68%
+16.31%
-0.74%
+19.78%
+0.47%
-0.13%
-0.13%
-0.07%
+2.28%
+19.61%
+0.01%
0.00%
+42.22%
+0.01%
+0.01%
-67.93%
+0.26%
-0.16%
-0.00%
+0.57%
4 (0)
3 (0)
10 (0)
8 (0)
673 (-586)
8 (0)
2 (0)
53 (0)
3 (0)
9 (-5)
19 (0)
15 (0)
5 (0)
4 (0)
1 (0)
3 (0)
74 (-73)
1 (0)
148 (+73)
75 (0)
1 (0)
1 (0)
50 (-1)
5 (0)
1 (0)
1 (0)
2 (0)
GettersFacetWrapper 2,192,875 (+12,234) getBridgehub
getProtocolVersion
getTotalBlocksExecuted
isDiamondStorageFrozen
util_setFirstUnprocessedPriorityTx
util_setIsDiamondStorageFrozen
util_setL2SystemContractsUpgradeTxHash
util_setValidator
398 (-42)
381 (-23)
405 (+45)
427 (+22)
45,822 (-44)
43,729 (+22)
43,999 (+22)
24,370 (+22)
-9.55%
-5.69%
+12.50%
+5.43%
-0.10%
+0.05%
+0.05%
+0.09%
398 (-42)
381 (-23)
405 (+45)
427 (+22)
45,822 (-44)
43,729 (+22)
43,999 (+22)
34,326 (+22)
-9.55%
-5.69%
+12.50%
+5.43%
-0.10%
+0.05%
+0.05%
+0.06%
398 (-42)
381 (-23)
405 (+45)
427 (+22)
45,822 (-44)
43,729 (+22)
43,999 (+22)
34,326 (+22)
-9.55%
-5.69%
+12.50%
+5.43%
-0.10%
+0.05%
+0.05%
+0.06%
398 (-42)
381 (-23)
405 (+45)
427 (+22)
45,822 (-44)
43,729 (+22)
43,999 (+22)
44,282 (+22)
-9.55%
-5.69%
+12.50%
+5.43%
-0.10%
+0.05%
+0.05%
+0.05%
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
2 (0)
TestExecutor 3,484,949 (+392,229) commitBatchesSharedBridge
executeBatchesSharedBridge
proveBatchesSharedBridge
setPriorityTreeStartIndex
7,814 (-45)
7,791 (-226)
7,813 (-198)
22,310 (-22)
-0.57%
-2.82%
-2.47%
-0.10%
30,575 (+2,533)
7,791 (-226)
7,813 (-198)
22,310 (-22)
+9.03%
-2.82%
-2.47%
-0.10%
30,086 (+2,387)
7,791 (-226)
7,813 (-198)
22,310 (-22)
+8.62%
-2.82%
-2.47%
-0.10%
46,788 (+2,846)
7,791 (-226)
7,813 (-198)
22,310 (-22)
+6.48%
-2.82%
-2.47%
-0.10%
15 (0)
1 (0)
1 (0)
1 (0)
MerkleTest 520,004 (+20,869) calculateRoot(bytes32[],bytes32[],uint256,bytes32[])
calculateRoot(bytes32[],uint256,bytes32)
1,595 (+481)
565 (0)
+43.18%
0.00%
5,731 (+419)
2,930 (+1)
+7.89%
+0.03%
1,856 (+399)
2,982 (0)
+27.39%
0.00%
13,520 (+366)
3,037 (+11)
+2.78%
+0.36%
8 (0)
265 (0)
L1ERC20Bridge 1,380,432 (+46,036) claimFailedDeposit
deposit(address,address,uint256,uint256,uint256)
deposit(address,address,uint256,uint256,uint256,address)
depositAmount
finalizeWithdrawal
initialize
isWithdrawalFinalized
l2Bridge
l2TokenAddress
l2TokenBeacon
l2TokenProxyBytecodeHash
30,864 (+12)
27,793 (-10)
27,978 (+13)
755 (+8)
30,168 (0)
23,581 (+66)
581 (+22)
379 (+45)
1,242 (+6)
379 (-22)
306 (-22)
+0.04%
-0.04%
+0.05%
+1.07%
0.00%
+0.28%
+3.94%
+13.47%
+0.49%
-5.49%
-6.71%
39,141 (-36)
62,873 (+20)
71,839 (+43)
1,281 (+8)
37,347 (+1,985)
23,581 (+66)
1,152 (+22)
879 (+45)
1,242 (+6)
879 (-22)
806 (-22)
-0.09%
+0.03%
+0.06%
+0.63%
+5.61%
+0.28%
+1.95%
+5.40%
+0.49%
-2.44%
-2.66%
40,790 (-44)
77,227 (+32)
77,910 (+55)
755 (+8)
39,619 (+2,819)
23,581 (+66)
581 (+22)
379 (+45)
1,242 (+6)
379 (-22)
306 (-22)
-0.11%
+0.04%
+0.07%
+1.07%
+7.66%
+0.28%
+3.94%
+13.47%
+0.49%
-5.49%
-6.71%
41,831 (-57)
94,347 (+19)
91,374 (+42)
2,755 (+8)
40,748 (+2,806)
23,581 (+66)
2,581 (+22)
2,379 (+45)
1,242 (+6)
2,379 (-22)
2,306 (-22)
-0.14%
+0.02%
+0.05%
+0.29%
+7.40%
+0.28%
+0.86%
+1.93%
+0.49%
-0.92%
-0.95%
5 (0)
12 (0)
6 (0)
19 (0)
6 (0)
1 (0)
7 (0)
4 (0)
1 (0)
4 (0)
4 (0)
DiamondProxy 2,475,597 (+12) commitBatchesSharedBridge
executeBatchesSharedBridge
finalizeEthWithdrawal
getAdmin
getChainId
getPriorityTreeRoot
proveBatchesSharedBridge
requestL2Transaction
setPriorityTreeStartIndex
util_setChainId
0 (0)
40,124 (+493)
37,590 (+22)
1,128 (+22)
5,113 (+22)
1,490 (+22)
42,767 (+82)
33,146 (0)
50,749 (-22)
28,906 (0)
+∞%
+1.24%
+0.06%
+1.99%
+0.43%
+1.50%
+0.19%
0.00%
-0.04%
0.00%
35,116 (+1,631)
40,124 (+493)
76,138 (-219)
5,178 (+22)
9,113 (+22)
6,740 (+22)
42,767 (+82)
128,879 (-730)
50,749 (-22)
33,763 (+30)
+4.87%
+1.24%
-0.29%
+0.43%
+0.24%
+0.33%
+0.19%
-0.56%
-0.04%
+0.09%
21,603 (+331)
40,124 (+493)
76,755 (+181)
5,128 (+22)
9,613 (+22)
6,740 (+22)
42,767 (+82)
166,296 (0)
50,749 (-22)
33,718 (0)
+1.56%
+1.24%
+0.24%
+0.43%
+0.23%
+0.33%
+0.19%
0.00%
-0.04%
0.00%
91,803 (+4,074)
40,124 (+493)
77,007 (+133)
9,628 (+22)
9,613 (+22)
11,990 (+22)
42,767 (+82)
188,247 (-2,188)
50,749 (-22)
34,090 (0)
+4.64%
+1.24%
+0.17%
+0.23%
+0.23%
+0.18%
+0.19%
-1.15%
-0.04%
0.00%
30 (0)
1 (0)
257 (0)
10 (0)
9 (0)
2 (0)
1 (0)
771 (0)
1 (0)
519 (0)
ValidatorTimelock 987,789 (-143,331) addValidator
chainTypeManager
commitBatchesSharedBridge
executeBatchesSharedBridge
executionDelay
getCommittedBatchTimestamp
proveBatchesSharedBridge
removeValidator
revertBatchesSharedBridge
setChainTypeManager
validators
29,438 (-22)
401 (+44)
30,410 (+565)
26,668 (+462)
357 (-44)
618 (-22)
28,098 (+70)
29,460 (+44)
23,916 (-33)
24,027 (-22)
702 (+44)
-0.07%
+12.32%
+1.89%
+1.76%
-10.97%
-3.44%
+0.25%
+0.15%
-0.14%
-0.09%
+6.69%
52,443 (-22)
1,401 (+44)
57,593 (+326)
33,061 (+330)
1,357 (-44)
1,618 (-22)
33,230 (+72)
30,889 (+44)
27,283 (-30)
44,530 (-22)
1,702 (+44)
-0.04%
+3.24%
+0.57%
+1.01%
-3.14%
-1.34%
+0.22%
+0.14%
-0.11%
-0.05%
+2.65%
53,355 (-22)
1,401 (+44)
63,028 (+278)
31,171 (+250)
1,357 (-44)
1,618 (-22)
33,230 (+72)
31,479 (+44)
23,928 (-33)
46,097 (-22)
1,702 (+44)
-0.04%
+3.24%
+0.44%
+0.81%
-3.14%
-1.34%
+0.22%
+0.14%
-0.14%
-0.05%
+2.65%
53,355 (-22)
2,401 (+44)
63,040 (+278)
41,344 (+277)
2,357 (-44)
2,618 (-22)
38,362 (+73)
31,730 (+44)
34,007 (-22)
46,097 (-22)
2,702 (+44)
-0.04%
+1.87%
+0.44%
+0.67%
-1.83%
-0.83%
+0.19%
+0.14%
-0.06%
-0.05%
+1.66%
50 (0)
2 (0)
6 (0)
3 (0)
2 (0)
2 (0)
2 (0)
3 (0)
3 (0)
25 (0)
10 (0)
VerifierTest 3,772,418 (-24,450) verificationKeyHash
verify
998 (-33)
3,966 (-245)
-3.20%
-5.82%
998 (-33)
135,204 (-245)
-3.20%
-0.18%
998 (-33)
3,966 (-245)
-3.20%
-5.82%
998 (-33)
360,630 (-245)
-3.20%
-0.07%
1 (0)
11 (0)
VerifierRecursiveTest 3,772,850 (-24,378) verificationKeyHash
verify
999 (-33)
4,276 (-248)
-3.20%
-5.48%
999 (-33)
137,522 (-248)
-3.20%
-0.18%
999 (-33)
4,276 (-248)
-3.20%
-5.48%
999 (-33)
374,006 (-248)
-3.20%
-0.07%
1 (0)
14 (0)
DummyBridgehubSetter 5,378,942 (+78,902) acceptOwnership
addChainTypeManager
addTokenAssetId
chainTypeManager
initialize
owner
proveL1ToL2TransactionStatus
proveL2LogInclusion
setCTM
setPendingAdmin
setZKChain
25,526 (+67)
23,865 (0)
24,156 (0)
530 (-22)
24,111 (+22)
384 (-22)
0 (0)
0 (0)
44,193 (+45)
25,880 (-12)
111,315 (0)
+0.26%
0.00%
0.00%
-3.99%
+0.09%
-5.42%
+∞%
+∞%
+0.10%
-0.05%
0.00%
25,526 (+67)
41,117 (+1)
36,579 (-22)
2,030 (-22)
24,111 (+22)
1,942 (-22)
1,356 (-25)
1,426 (-43)
44,232 (+47)
41,536 (-26)
111,354 (+2)
+0.26%
+0.00%
-0.06%
-1.07%
+0.09%
-1.12%
-1.81%
-2.93%
+0.11%
-0.06%
+0.00%
25,526 (+67)
47,558 (0)
36,917 (-39)
2,530 (-22)
24,111 (+22)
2,384 (-22)
964 (-5)
1,060 (0)
44,253 (+57)
49,541 (0)
111,375 (+12)
+0.26%
0.00%
-0.11%
-0.86%
+0.09%
-0.91%
-0.52%
0.00%
+0.13%
0.00%
+0.01%
25,526 (+67)
47,558 (0)
47,583 (0)
2,530 (-22)
24,111 (+22)
2,384 (-22)
3,571 (-36)
3,785 (-7)
44,253 (+45)
49,757 (0)
111,375 (0)
+0.26%
0.00%
0.00%
-0.86%
+0.09%
-0.91%
-1.00%
-0.18%
+0.10%
0.00%
0.00%
17 (0)
3,584 (0)
1,536 (0)
1,024 (0)
17 (0)
1,314 (0)
512 (0)
512 (0)
768 (0)
1,279 (+1)
768 (0)
Utils 6,037,668 (-32,049) constructRollupL2DAValidatorOutputHash
createCommitBatchInfo
getExecutorSelectors
getGettersSelectors
getMailboxSelectors
makeInitializeDataForNewChain
randomBytes32
1,364 (-22)
4,131 (-22)
1,206 (-22)
6,290 (-22)
1,814 (+44)
2,050 (+45)
1,062 (-22)
-1.59%
-0.53%
-1.79%
-0.35%
+2.49%
+2.24%
-2.03%
1,370 (-22)
4,131 (-22)
1,206 (-22)
6,290 (-22)
1,814 (+44)
2,050 (+45)
1,066 (-22)
-1.58%
-0.53%
-1.79%
-0.35%
+2.49%
+2.24%
-2.02%
1,364 (-22)
4,131 (-22)
1,206 (-22)
6,290 (-22)
1,814 (+44)
2,050 (+45)
1,062 (-22)
-1.59%
-0.53%
-1.79%
-0.35%
+2.49%
+2.24%
-2.03%
1,522 (-22)
4,131 (-22)
1,206 (-22)
6,290 (-22)
1,814 (+44)
2,050 (+45)
1,144 (-22)
-1.42%
-0.53%
-1.79%
-0.35%
+2.49%
+2.24%
-1.89%
25 (0)
6 (0)
25 (0)
56 (0)
36 (0)
48 (0)
514 (0)
PriorityTreeTest 998,915 (-5,625) initFromCommitment
processBatch
push
54,070 (-17)
23,662 (+1,072)
90,757 (-1)
-0.03%
+4.75%
-0.00%
54,070 (-17)
37,372 (+826)
104,707 (-1)
-0.03%
+2.26%
-0.00%
54,070 (-17)
36,254 (+809)
109,056 (-1)
-0.03%
+2.28%
-0.00%
54,070 (-17)
53,319 (+614)
116,710 (-1)
-0.03%
+1.16%
-0.00%
1 (0)
4 (0)
14 (0)
ChainTypeManager 4,547,000 (0) createNewChain
getHyperchain
1,053 (0)
1,606 (+22)
0.00%
+1.39%
3,156,993 (+40)
1,606 (+22)
+0.00%
+1.39%
3,575,898 (+44)
1,606 (+22)
+0.00%
+1.39%
3,575,898 (+44)
1,606 (+22)
+0.00%
+1.39%
17 (0)
15 (0)
GettersFacet 1,152,473 (+8,853) getAdmin
getChainId
getPriorityTreeRoot
396 (+22)
2,381 (+22)
758 (+22)
+5.88%
+0.93%
+2.99%
2,196 (+22)
2,381 (+22)
2,758 (+22)
+1.01%
+0.93%
+0.80%
2,396 (+22)
2,381 (+22)
2,758 (+22)
+0.93%
+0.93%
+0.80%
2,396 (+22)
2,381 (+22)
4,758 (+22)
+0.93%
+0.93%
+0.46%
10 (0)
9 (0)
2 (0)
Bridgehub 5,341,942 (+79,022) createNewChain
getZKChain
l1CtmDeployer
setAddresses
4,072,722 (+117)
758 (+22)
2,390 (+22)
70,938 (-22)
+0.00%
+2.99%
+0.93%
-0.03%
4,072,722 (+117)
2,920 (+22)
2,390 (+22)
70,938 (-22)
+0.00%
+0.76%
+0.93%
-0.03%
4,072,722 (+117)
2,758 (+22)
2,390 (+22)
70,938 (-22)
+0.00%
+0.80%
+0.93%
-0.03%
4,072,722 (+117)
5,039 (+22)
2,390 (+22)
70,938 (-22)
+0.00%
+0.44%
+0.93%
-0.03%
15 (0)
40 (0)
15 (0)
15 (0)
ChainAdmin 909,847 (0) multicall
setUpgradeTimestamp
27,048 (0)
25,361 (-19,912)
0.00%
-43.98%
43,162 (0)
45,005 (-396)
0.00%
-0.87%
43,485 (0)
45,321 (-6)
0.00%
-0.01%
64,230 (+44)
45,645 (0)
+0.07%
0.00%
515 (0)
256 (0)
MailboxFacet 3,287,412 (+28,859) finalizeEthWithdrawal
requestL2Transaction
8,101 (+22)
3,139 (0)
+0.27%
0.00%
48,835 (-238)
99,106 (-727)
-0.48%
-0.73%
49,490 (+133)
135,326 (0)
+0.27%
0.00%
49,490 (+133)
159,775 (-2,188)
+0.27%
-1.35%
257 (0)
771 (0)
TestnetERC20Token 800,383 (0) allowance
approve
balanceOf
mint
753 (0)
24,247 (-12)
0 (0)
34,018 (-12)
0.00%
-0.05%
+∞%
-0.04%
2,510 (+16)
45,901 (+119)
1,388 (-7)
52,354 (-280)
+0.64%
+0.26%
-0.50%
-0.53%
2,753 (0)
46,171 (0)
558 (0)
51,130 (0)
0.00%
0.00%
0.00%
0.00%
2,753 (0)
46,171 (0)
2,558 (0)
68,602 (0)
0.00%
0.00%
0.00%
0.00%
33 (+2)
232 (+73)
50 (-2)
399 (+73)
PermanentRestriction 1,147,705 (0) allowAdminImplementation
setAllowedData
setSelectorIsValidated
tryCompareAdminOfAChain
validateCall
47,494 (0)
48,233 (0)
47,583 (0)
453 (0)
25,921 (+66)
0.00%
0.00%
0.00%
0.00%
+0.26%
47,758 (+9)
49,265 (-25)
47,615 (+2)
19,117 (+54)
28,254 (+66)
+0.02%
-0.05%
+0.00%
+0.28%
+0.23%
47,866 (0)
48,884 (-84)
47,631 (0)
24,170 (+66)
28,551 (+66)
0.00%
-0.17%
0.00%
+0.27%
+0.23%
47,866 (0)
51,029 (0)
47,631 (0)
24,170 (+66)
29,953 (+66)
0.00%
0.00%
0.00%
+0.27%
+0.22%
258 (0)
257 (0)
258 (0)
11 (0)
7 (0)
GenerateForceDeploymentsData 1,605,524 (-11,459) run 175,922 (-77) -0.04% 175,922 (-77) -0.04% 175,922 (-77) -0.04% 175,922 (-77) -0.04% 3 (+1)
AccessControlRestriction 1,759,703 (0) grantRole
setRequiredRoleForCall
setRequiredRoleForFallback
51,036 (0)
48,605 (0)
47,940 (0)
0.00%
0.00%
0.00%
51,271 (-3)
49,422 (+3)
48,848 (-5)
-0.01%
+0.01%
-0.01%
51,408 (0)
48,977 (0)
48,312 (0)
0.00%
0.00%
0.00%
51,408 (0)
51,877 (0)
51,658 (0)
0.00%
0.00%
0.00%
1,024 (0)
1,280 (0)
1,280 (0)
MerkleTreeNoSort 583,114 (0) getProof 2,608 (0) 0.00% 32,753 (-3) -0.01% 33,207 (0) 0.00% 33,229 (0) 0.00% 277 (0)
DiamondCutTestContract 2,429,624 (+8,889) diamondCut 23,653 (0) 0.00% 203,351 (+2) +0.00% 44,650 (0) 0.00% 1,437,433 (+12) +0.00% 20 (0)
DummySharedBridge 1,594,156 (-4,521)
DummyZKChain 3,553,925 (+28,933)
IncrementalMerkleTest 365,381 (-12)
ReenterL1ERC20Bridge 406,580 (-12)
AdminFacet 4,598,143 (+12)
DefaultUpgrade 1,671,236 (+12)

Copy link

Coverage after merging kl/merge-stable into kl/sync-layer-reorg will be

85.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
../da-contracts/contracts
   RollupL1DAValidator.sol61.04%31.25%83.33%67.27%145, 148, 148, 148, 150, 183–184, 187–188, 27, 27–28, 30, 30–31, 34, 36–37, 41–42, 65, 67, 67, 67–68, 70, 80, 80–81
contracts/bridge
   BridgeHelper.sol100%100%100%100%
   BridgedStandardERC20.sol75%25%100%76.92%108–109, 114–115, 127–128, 151–152, 193, 193, 200, 200, 207, 207, 53–54, 80–81
   L1ERC20Bridge.sol93.18%80%100%93.75%122, 225–226
   L1Nullifier.sol80.37%68%80.65%84.96%110–111, 126, 126–127, 134, 134–135, 142–143, 172–173, 196, 216, 223–224, 226–227, 236–237, 245–246, 248, 416, 444–445, 466–467, 506, 591, 683, 685, 687, 699, 713, 718
contracts/bridge/asset-router
   AssetRouterBase.sol77.50%40%87.50%81.48%143–144, 57–58, 85–86, 94–95
   L1AssetRouter.sol90.13%72%92%94.12%202–203, 239, 248, 250, 253, 56–57, 572, 72–73, 80–81
contracts/bridge/ntv
   L1NativeTokenVault.sol95.29%94.44%90%96.49%205, 205–206
   NativeTokenVault.sol89.06%76.19%89.47%92.05%196, 198, 234–235, 334, 336, 348–349, 400, 405, 66–67
contracts/bridgehub
   Bridgehub.sol64.50%27.94%77.78%72.89%111, 111–112, 118–119, 126–127, 133–134, 140, 140–141, 175–176, 219, 219–220, 222–223, 223, 223–224, 230–231, 231–232, 234, 234–235, 237–238, 238–239, 241, 249–250, 264–265, 314–315, 317–318, 375–376, 386–387, 391, 391–392, 394, 422–423, 448–450, 453, 453–454, 498, 506–508, 512, 512–513, 515, 527–528, 540–541, 593, 612–613, 692, 695–696, 700–701, 734–735, 748, 791–792, 794–795, 797–798, 824–825, 828–829, 832–833, 836–837, 839–840, 843–844, 847–848, 851–852, 854–855, 865, 870, 875, 880, 889
   CTMDeploymentTracker.sol79.07%50%90%94.74%115, 119, 34, 41, 64, 91, 94, 96
   MessageRoot.sol91.07%63.64%100%96.97%116–117, 148, 69, 87
contracts/common
   ReentrancyGuard.sol90%66.67%100%92.86%78–79
contracts/common/libraries
   DataEncoding.sol77.27%50%100%76.92%108, 112, 117, 75, 83
   DynamicIncrementalMerkle.sol74.42%100%80%72.22%67–70, 72–74, 76–78
   FullMerkle.sol100%100%100%100%
   L2ContractHelper.sol44.44%0%50%52%100, 100–101, 109, 139, 143, 56, 68–69, 74–75, 78–79, 93, 95, 95–96
   Merkle.sol96.61%90.91%100%97.67%80–81
   MessageHashing.sol100%100%100%100%
   SemVer.sol100%100%100%100%
   SystemContractsCaller.sol0%0%0%0%114, 122–125, 135–138, 138–139, 141, 141–142, 33, 33–34, 37, 45, 47, 49, 51, 53, 66, 66, 66, 69, 72, 75, 78, 89, 91, 93, 96, 98
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol84.21%100%83.33%84.62%35–36
contracts/governance
   AccessControlRestriction.sol100%100%100%100%
   ChainAdmin.sol95.12%80%100%96.15%27–28
   Governance.sol98.15%94.74%100%98.55%45–46
   PermanentRestriction.sol87.32%78.57%100%87.23%142, 142–143, 146, 148, 148–149, 176–177
contracts/state-transition
   ChainTypeManager.sol67.28%33.33%60%77.67%108, 135–136, 138–139, 141–142, 144–145, 200–201, 245, 252, 270, 276, 283, 295, 302, 309, 317, 324, 332, 339, 357, 359, 424, 443, 443, 443, 446, 446, 446, 448, 461, 466, 491, 74, 87–88
   TestnetVerifier.sol77.78%66.67%100%75%16, 28
   ValidatorTimelock.sol95.08%83.33%100%95.24%200, 82–83
   Verifier.sol89.90%40%96.30%90.93%1674–1675, 287–302, 305–308, 311–318, 321–328, 331–332, 335–336, 339, 383–384, 394–395, 405–406, 416–417, 427–428, 443–444, 453, 453–454, 905–906
contracts/state-transition/chain-deps
   DiamondInit.sol78%45.45%100%86.49%39–40, 42–43, 45–46, 48–49, 51–52, 77
   DiamondProxy.sol92.31%75%100%100%16, 27
contracts/state-transition/chain-deps/facets
   Admin.sol72.69%36.21%90.91%85.29%104–105, 115–116, 130, 130–131, 133–134, 157, 157, 157–158, 158, 158, 160, 239, 241, 254–255, 261, 263, 266, 266, 266, 284, 295–296, 301, 313, 313, 315, 315, 315, 321, 321, 321–322, 322, 322–324, 324, 324–325, 325, 325–327, 354, 356, 360, 369, 379, 383, 40, 40
   Executor.sol75.48%55.84%92%80.77%120–121, 173, 178, 183, 188, 193, 198,

@kelemeno kelemeno merged commit 8479868 into kl/sync-layer-reorg Sep 10, 2024
25 checks passed
@kelemeno kelemeno deleted the kl/merge-stable branch September 10, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants