Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge dev into kl/sync-layer-reorg #721

Merged
merged 19 commits into from
Aug 20, 2024
Merged

Merge dev into kl/sync-layer-reorg #721

merged 19 commits into from
Aug 20, 2024

Conversation

StanislavBreadless
Copy link
Collaborator

What ❔

Some tests were commented out since there was too much to change.
They will be uncommented as part of another general testing effort for the kl/sync-layer-reorg

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

neotheprogramist and others added 16 commits June 27, 2024 19:16
@neotheprogramist @tommysr
Mailbox unit testing (#489)
8fec7ec 
Co-authored-by: tommysr <[email protected]>
@saxenism
Revert "Mailbox unit testing (#489)" (#558)
116206c 
CI checks were failing in the earlier branch
@artmakh
chore(ci): Additional permissions for CI token (#565)
fb3a5d8
@tommysr
Mailbox unit testing (#559)
1c1b93b 
Failing CI check is for coverage and for external contributors, they are not permissioned enough to run this check. The reason being Github doesn't allow granting anything except read for tokens, when PR is from fork https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
@benceharomi
chore: zksync-ethers to stable v5.9.0 (#567)
c9a8a68
@kelemeno
remove outdated folder (#601)
bc98e4b
@koloz193
Merge branch 'main' into zk-sync-main-dev
c808b1f
@StanislavBreadless
Merge pull request #678 from matter-labs/zk-sync-main-dev
5b8d6ae 
Merge Main into Dev
@vladbochok @perekopskiy @Deniallugo
Add chain contract (#598)
b62ca53 
Signed-off-by: Danil <[email protected]>
Co-authored-by: perekopskiy <[email protected]>
Co-authored-by: perekopskiy <[email protected]>
Co-authored-by: Danil <[email protected]>
@StanislavBreadless
sync main with dev
3161150
@StanislavBreadless
Merge pull request #681 from matter-labs/sb-merge-main-into-dev
0b80914 
Merge main into dev
@ischasny
feat: add tokenMultiplierSetter role to deployment scripts (#683)
7ca5517
@Deniallugo
Merge branch 'main' into deniallugo-merge-main
1812c31
@StanislavBreadless
Merge pull request #696 from matter-labs/deniallugo-merge-main
d0d735c 
merge main
@neotheprogramist @tommysr
Bridgehub Test Coverage Increase (#494)
118f081 
Co-authored-by: tommysr <[email protected]>
@StanislavBreadless
merge dev into the kl sync layer reorg
9b24cce
@github-actions GitHub Actions
Copy link

Changes to gas cost

Generated at commit: f16b75ba7575bde264007bd6001bac1c248fa695, compared to commit: 8f4aad417566234528470df8a6c8a7c9a40d0876

🧾 Summary (100% most significant diffs)

Contract Method Avg (+/-) %
UtilsFacet util_getStoredBatchHashes
util_getVerifierParams
util_setBaseTokenGasPriceMultiplierDenominator
util_setFeeParams
util_setIsFrozen
util_setProtocolVersion
util_setTransactionFilterer
util_setValidator
util_setZkPorterAvailability		 +22 ❌
-89 ✅
-11 ✅
+1,120 ❌
+22 ❌
+22 ❌
+88 ❌
-22 ✅
+22 ❌		 +3.64%
-10.80%
-0.05%
+26.66%
+0.21%
+0.10%
+0.39%
-0.17%
+0.18%
MerkleTreeNoSort getProof
getRoot		 -440 ✅
-6,370 ✅		 -1.33%
-21.10%
MailboxFacet bridgehubRequestL2Transaction -18,465 ✅ -19.46%
DummyBridgehubSetter acceptAdmin
setHyperchain
setPendingAdmin
setSTM		 -7,798 ✅
+1 ❌
+3,653 ❌
+1 ❌		 -16.62%
+0.00%
+9.64%
+0.00%
DiamondProxy bridgehubRequestL2Transaction
executeUpgrade
util_getBaseTokenBridge
util_getChainId
util_getL2BootloaderBytecodeHash
util_getL2DefaultAccountBytecodeHash
util_getPriorityTxMaxGasLimit
util_getProtocolVersion
util_getStateTransitionManager
util_getStoredBatchHashes
util_getVerifier
util_getVerifierParams
util_getZkPorterAvailability
util_setBaseTokenGasPriceMultiplierDenominator
util_setFeeParams
util_setIsFrozen
util_setProtocolVersion
util_setTransactionFilterer
util_setValidator
util_setZkPorterAvailability		 -18,044 ✅
-19,625 ✅
+22 ❌
+22 ❌
-88 ✅
+22 ❌
-22 ✅
+22 ❌
+22 ❌
+22 ❌
-22 ✅
-89 ✅
+22 ❌
-11 ✅
+1,122 ❌
+22 ❌
+22 ❌
+88 ❌
-22 ✅
+22 ❌		 -14.49%
-6.34%
+1.81%
+0.71%
-7.43%
+2.01%
-0.87%
+2.01%
+0.25%
+1.59%
-1.83%
-5.54%
+0.70%
-0.02%
+3.35%
+0.06%
+0.04%
+0.17%
-0.05%
+0.05%
AdminFacet executeUpgrade -38,080 ✅ -11.02%
Utils getGettersSelectors
getUtilsFacetSelectors		 +115 ❌
+674 ❌		 +1.62%
+7.53%
L1ERC20Bridge claimFailedDeposit
deposit(address,address,uint256,uint256,uint256)
deposit(address,address,uint256,uint256,uint256,address)
finalizeWithdrawal		 +2,869 ❌
-234 ✅
-472 ✅
-1,236 ✅		 +7.41%
-0.37%
-0.65%
-3.36%
StateTransitionManager createNewChain
initialize
setChainCreationParams
setNewVersionUpgrade
setUpgradeDiamondCut		 +249 ❌
+269 ❌
+566 ❌
+1,884 ❌
+565 ❌		 +1.85%
+0.24%
+1.25%
+1.25%
+1.21%
TransparentUpgradeableProxy createNewChain
setChainCreationParams
setNewVersionUpgrade
setUpgradeDiamondCut		 +881 ❌
+1,173 ❌
+2,503 ❌
+1,184 ❌		 +1.31%
+1.20%
+1.23%
+1.21%
MerkleTest calculateRoot(bytes32[],uint256,bytes32) -29 ✅ -0.99%
DummySharedBridge setNativeTokenVault +25 ❌ +0.06%
DiamondCutTestContract diamondCut +2 ❌ +0.00%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
UtilsFacet 704,752 (+37,214) util_getBaseTokenBridge
util_getChainId
util_getL2BootloaderBytecodeHash
util_getL2DefaultAccountBytecodeHash
util_getPriorityTxMaxGasLimit
util_getProtocolVersion
util_getStateTransitionManager
util_getStoredBatchHashes
util_getVerifier
util_getVerifierParams
util_getZkPorterAvailability
util_setBaseTokenGasPriceMultiplierDenominator
util_setFeeParams
util_setIsFrozen
util_setProtocolVersion
util_setTransactionFilterer
util_setValidator
util_setZkPorterAvailability		 464 (+22)
368 (+22)
325 (-88)
348 (+22)
392 (-22)
346 (+22)
462 (+22)
626 (+22)
409 (-22)
735 (-89)
414 (+22)
5,430 (-17,078)
4,201 (0)
605 (+22)
22,464 (+22)
22,585 (+88)
2,771 (-22)
2,582 (+22)		 +4.98%
+6.36%
-21.31%
+6.75%
-5.31%
+6.79%
+5.00%
+3.64%
-5.10%
-10.80%
+5.61%
-75.88%
0.00%
+3.77%
+0.10%
+0.39%
-0.79%
+0.86%		 464 (+22)
368 (+22)
325 (-88)
348 (+22)
1,058 (-22)
346 (+22)
2,308 (+22)
626 (+22)
409 (-22)
735 (-89)
414 (+22)
22,497 (-11)
5,321 (+1,120)
10,555 (+22)
22,464 (+22)
22,585 (+88)
12,721 (-22)
12,532 (+22)		 +4.98%
+6.36%
-21.31%
+6.75%
-2.04%
+6.79%
+0.96%
+3.64%
-5.10%
-10.80%
+5.61%
-0.05%
+26.66%
+0.21%
+0.10%
+0.39%
-0.17%
+0.18%		 464 (+22)
368 (+22)
325 (-88)
348 (+22)
392 (-22)
346 (+22)
2,462 (+22)
626 (+22)
409 (-22)
735 (-89)
414 (+22)
22,530 (+22)
4,201 (0)
10,555 (+22)
22,464 (+22)
22,585 (+88)
12,721 (-22)
12,532 (+22)		 +4.98%
+6.36%
-21.31%
+6.75%
-5.31%
+6.79%
+0.90%
+3.64%
-5.10%
-10.80%
+5.61%
+0.10%
0.00%
+0.21%
+0.10%
+0.39%
-0.17%
+0.18%		 464 (+22)
368 (+22)
325 (-88)
348 (+22)
2,392 (-22)
346 (+22)
2,462 (+22)
626 (+22)
409 (-22)
735 (-89)
414 (+22)
22,530 (+22)
7,001 (+2,800)
20,505 (+22)
22,464 (+22)
22,585 (+88)
22,671 (-22)
22,482 (+22)		 +4.98%
+6.36%
-21.31%
+6.75%
-0.91%
+6.79%
+0.90%
+3.64%
-5.10%
-10.80%
+5.61%
+0.10%
+66.65%
+0.11%
+0.10%
+0.39%
-0.10%
+0.10%		 1 (0)
1 (0)
1 (0)
1 (0)
3 (0)
1 (0)
13 (0)
1 (0)
1 (0)
1 (0)
2 (0)
522 (+518)
5 (+2)
2 (0)
3 (0)
3 (0)
4 (0)
2 (0)
MerkleTreeNoSort 534,636 (0) getProof
getRoot		 2,594 (-30,359)
1,526 (-28,662)		 -92.13%
-94.95%		 32,739 (-440)
23,818 (-6,370)		 -1.33%
-21.10%		 33,193 (0)
30,188 (0)		 0.00%
0.00%		 33,215 (0)
30,188 (0)		 0.00%
0.00%		 277 (+4)
18 (+4)
MailboxFacet 3,008,460 (0) bridgehubRequestL2Transaction 2,570 (-13,756) -84.26% 76,429 (-18,465) -19.46% 119,622 (0) 0.00% 124,008 (0) 0.00% 5 (+1)
DummyBridgehubSetter 3,996,991 (0) acceptAdmin
addStateTransitionManager
owner
proveL1ToL2TransactionStatus
proveL2LogInclusion
removeStateTransitionManager
setHyperchain
setPendingAdmin
setSTM		 23,521 (-23,393)
23,853 (0)
430 (0)
0 (0)
0 (0)
23,851 (0)
111,384 (0)
25,965 (0)
44,187 (0)		 -49.86%
0.00%
0.00%
+∞%
+∞%
0.00%
0.00%
0.00%
0.00%		 39,116 (-7,798)
41,114 (+1)
1,988 (-331)
1,392 (-21)
1,549 (+16)
25,500 (-2)
111,422 (+1)
41,561 (+3,653)
44,225 (+1)		 -16.62%
+0.00%
-14.27%
-1.49%
+1.04%
-0.01%
+0.00%
+9.64%
+0.00%		 46,914 (0)
47,544 (0)
2,430 (0)
985 (0)
1,133 (0)
25,861 (0)
111,444 (+12)
49,569 (+11,694)
44,247 (+12)		 0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
+0.01%
+30.88%
+0.03%		 46,914 (0)
47,544 (0)
2,430 (0)
3,639 (0)
3,939 (+7)
26,318 (0)
111,444 (0)
49,785 (0)
44,247 (0)		 0.00%
0.00%
0.00%
0.00%
+0.18%
0.00%
0.00%
0.00%
0.00%		 768 (+512)
3,584 (0)
1,314 (+772)
512 (0)
512 (0)
2,048 (0)
768 (0)
1,280 (+768)
768 (0)
DiamondProxy 1,891,185 (-539,810) bridgehubRequestL2Transaction
executeUpgrade
util_getBaseTokenBridge
util_getChainId
util_getL2BootloaderBytecodeHash
util_getL2DefaultAccountBytecodeHash
util_getPriorityTxMaxGasLimit
util_getProtocolVersion
util_getStateTransitionManager
util_getStoredBatchHashes
util_getVerifier
util_getVerifierParams
util_getZkPorterAvailability
util_setBaseTokenGasPriceMultiplierDenominator
util_setFeeParams
util_setIsFrozen
util_setProtocolVersion
util_setTransactionFilterer
util_setValidator
util_setZkPorterAvailability		 34,282 (-13,756)
31,872 (0)
1,235 (+22)
3,139 (+22)
1,096 (-88)
1,119 (+22)
1,163 (-22)
1,117 (+22)
1,233 (+22)
1,403 (+22)
1,180 (-22)
1,518 (-89)
3,185 (+22)
33,896 (-17,090)
33,529 (0)
29,071 (+22)
50,942 (+22)
51,291 (+88)
31,611 (-22)
31,048 (+22)		 -28.64%
0.00%
+1.81%
+0.71%
-7.43%
+2.01%
-1.86%
+2.01%
+1.82%
+1.59%
-1.83%
-5.54%
+0.70%
-33.52%
0.00%
+0.08%
+0.04%
+0.17%
-0.07%
+0.07%		 106,455 (-18,044)
289,707 (-19,625)
1,235 (+22)
3,139 (+22)
1,096 (-88)
1,119 (+22)
2,496 (-22)
1,117 (+22)
8,733 (+22)
1,403 (+22)
1,180 (-22)
1,518 (-89)
3,185 (+22)
50,975 (-11)
34,651 (+1,122)
39,027 (+22)
50,942 (+22)
51,291 (+88)
41,567 (-22)
41,004 (+22)		 -14.49%
-6.34%
+1.81%
+0.71%
-7.43%
+2.01%
-0.87%
+2.01%
+0.25%
+1.59%
-1.83%
-5.54%
+0.70%
-0.02%
+3.35%
+0.06%
+0.04%
+0.17%
-0.05%
+0.05%		 148,524 (0)
437,313 (-31,259)
1,235 (+22)
3,139 (+22)
1,096 (-88)
1,119 (+22)
1,163 (-22)
1,117 (+22)
9,733 (+22)
1,403 (+22)
1,180 (-22)
1,518 (-89)
3,185 (+22)
51,008 (+22)
33,529 (0)
39,027 (+22)
50,942 (+22)
51,291 (+88)
41,567 (-22)
41,004 (+22)		 0.00%
-6.67%
+1.81%
+0.71%
-7.43%
+2.01%
-1.86%
+2.01%
+0.23%
+1.59%
-1.83%
-5.54%
+0.70%
+0.04%
0.00%
+0.06%
+0.04%
+0.17%
-0.05%
+0.05%		 152,910 (0)
437,363 (-33,409)
1,235 (+22)
3,139 (+22)
1,096 (-88)
1,119 (+22)
5,163 (-22)
1,117 (+22)
9,733 (+22)
1,403 (+22)
1,180 (-22)
1,518 (-89)
3,185 (+22)
51,008 (+22)
36,341 (+2,812)
48,983 (+22)
50,942 (+22)
51,291 (+88)
51,523 (-22)
50,960 (+22)		 0.00%
-7.10%
+1.81%
+0.71%
-7.43%
+2.01%
-0.42%
+2.01%
+0.23%
+1.59%
-1.83%
-5.54%
+0.70%
+0.04%
+8.39%
+0.04%
+0.04%
+0.17%
-0.04%
+0.04%		 5 (+1)
5 (0)
1 (0)
1 (0)
1 (0)
1 (0)
3 (0)
1 (0)
13 (0)
1 (0)
1 (0)
1 (0)
2 (0)
522 (+518)
5 (+2)
2 (0)
3 (0)
3 (0)
4 (0)
2 (0)
AdminFacet 3,289,751 (0) executeUpgrade 2,684 (0) 0.00% 307,429 (-38,080) -11.02% 488,361 (-61,650) -11.21% 488,411 (-64,350) -11.64% 5 (0)
Utils 4,728,171 (+46,468) getGettersSelectors
getUtilsFacetSelectors		 7,197 (+115)
9,625 (+674)		 +1.62%
+7.53%		 7,197 (+115)
9,625 (+674)		 +1.62%
+7.53%		 7,197 (+115)
9,625 (+674)		 +1.62%
+7.53%		 7,197 (+115)
9,625 (+674)		 +1.62%
+7.53%		 40 (+21)
83 (+17)
L1ERC20Bridge 1,116,643 (0) claimFailedDeposit
deposit(address,address,uint256,uint256,uint256)
deposit(address,address,uint256,uint256,uint256,address)
depositAmount
finalizeWithdrawal		 41,050 (+9,661)
27,946 (0)
28,120 (0)
771 (0)
30,285 (0)		 +30.78%
0.00%
0.00%
0.00%
0.00%		 41,603 (+2,869)
63,256 (-234)
72,323 (-472)
1,297 (+65)
35,601 (-1,236)		 +7.41%
-0.37%
-0.65%
+5.28%
-3.36%		 41,594 (+75)
77,866 (0)
78,499 (0)
771 (0)
37,138 (-459)		 +0.18%
0.00%
0.00%
0.00%
-1.22%		 42,174 (-384)
94,830 (+12)
91,787 (-2,835)
2,771 (0)
38,177 (-2,135)		 -0.90%
+0.01%
-3.00%
0.00%
-5.30%		 4 (-2)
12 (0)
6 (0)
19 (-7)
6 (0)
StateTransitionManager 3,965,720 (0) createNewChain
initialize
setChainCreationParams
setNewVersionUpgrade
setUpgradeDiamondCut		 1,205 (0)
22,836 (0)
45,779 (+566)
152,968 (+1,884)
47,250 (+565)		 0.00%
0.00%
+1.25%
+1.25%
+1.21%		 13,728 (+249)
112,005 (+269)
45,779 (+566)
152,968 (+1,884)
47,250 (+565)		 +1.85%
+0.24%
+1.25%
+1.25%
+1.21%		 13,728 (+249)
22,836 (0)
45,779 (+566)
152,968 (+1,884)
47,250 (+565)		 +1.85%
0.00%
+1.25%
+1.25%
+1.21%		 26,252 (+498)
210,092 (+566)
45,779 (+566)
152,968 (+1,884)
47,250 (+565)		 +1.93%
+0.27%
+1.25%
+1.25%
+1.21%		 2 (0)
21 (0)
1 (0)
1 (0)
1 (0)
TransparentUpgradeableProxy 846,950 (+1,613) createNewChain
setChainCreationParams
setNewVersionUpgrade
setUpgradeDiamondCut		 55,551 (+632)
98,779 (+1,173)
205,430 (+2,503)
99,371 (+1,184)		 +1.15%
+1.20%
+1.23%
+1.21%		 68,074 (+881)
98,779 (+1,173)
205,430 (+2,503)
99,371 (+1,184)		 +1.31%
+1.20%
+1.23%
+1.21%		 68,074 (+881)
98,779 (+1,173)
205,430 (+2,503)
99,371 (+1,184)		 +1.31%
+1.20%
+1.23%
+1.21%		 80,598 (+1,130)
98,779 (+1,173)
205,430 (+2,503)
99,371 (+1,184)		 +1.42%
+1.20%
+1.23%
+1.21%		 2 (0)
1 (0)
1 (0)
1 (0)
MerkleTest 468,218 (0) calculateRoot(bytes32[],uint256,bytes32) 606 (0) 0.00% 2,892 (-29) -0.99% 2,943 (0) 0.00% 2,998 (+11) +0.37% 265 (+4)
DiamondInit 523,294 (0) initialize 22,660 (0) 0.00% 392,207 (+1,614) +0.41% 400,752 (0) 0.00% 420,652 (0) 0.00% 107 (+17)
L1NativeTokenVault 1,937,741 (0) registerToken 484 (0) 0.00% 80,682 (-148) -0.18% 82,362 (0) 0.00% 84,990 (0) 0.00% 195 (+4)
TestnetERC20Token 640,427 (-36) mint 34,043 (0) 0.00% 52,497 (-92) -0.17% 51,143 (0) 0.00% 68,615 (0) 0.00% 349 (-2)
DummySharedBridge 1,310,815 (+440,733) setNativeTokenVault 44,092 (+25) +0.06% 44,092 (+25) +0.06% 44,092 (+25) +0.06% 44,092 (+25) +0.06% 34 (+4)
DiamondCutTestContract 1,864,745 (0) diamondCut 23,741 (0) 0.00% 203,607 (+2) +0.00% 45,114 (0) 0.00% 1,422,576 (+48) +0.00% 20 (0)
DummyHyperchain 3,217,207 (+12,964)

@github-actions GitHub Actions
Copy link

Coverage after merging sb-merge-dev-kl-reorg into kl/sync-layer-reorg will be

89.99%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
../da-contracts/contracts
   RollupL1DAValidator.sol67.11%50%83.33%73.91%134, 137, 137, 137, 139, 170, 172, 25, 25, 25–26, 26, 26, 28, 30–31, 35–36, 59, 61, 61, 61–62, 64
contracts/bridge
   BridgeHelper.sol100%100%100%100%
   L1AssetRouter.sol95.19%89.29%94.87%97.88%137, 152, 209, 229, 274, 327, 379, 514, 531, 552, 735–736, 871
   L1ERC20Bridge.sol95%87.50%100%96%113, 99
   L1NativeTokenVault.sol96.12%97.62%84.62%97.30%251, 256, 44
contracts/bridgehub
   Bridgehub.sol71.81%45.57%78.95%84.51%104, 109, 115, 120, 120, 187, 187–188, 190–191, 191, 191–192, 198–199, 199, 199–200, 200, 200, 202–203, 203, 203–204, 268, 298–300, 302–304, 306, 332, 341, 346–347, 397–398, 400, 400, 400, 443, 451–452, 455, 455, 455–456, 478, 516, 540–541, 620, 623–624, 628–629, 656–657, 662–663, 691, 696, 99
   MessageRoot.sol91.38%61.54%100%100%156, 162, 69, 76, 94
   STMDeploymentTracker.sol79.49%50%90%94.12%110, 114, 31, 38, 61, 88, 91
contracts/common
   ReentrancyGuard.sol100%100%100%100%
contracts/common/libraries
   DataEncoding.sol80%100%100%66.67%72, 80
   DynamicIncrementalMerkle.sol74.42%100%80%72.22%67–70, 72–74, 76–78
   FullMerkle.sol100%100%100%100%
   L2ContractHelper.sol55.88%30%60%68.42%29, 32–33, 46–47, 47, 47, 49, 49, 49, 56, 86, 90
   Merkle.sol93.85%81.82%100%100%53–55, 83
   MessageHashing.sol100%100%100%100%
   SemVer.sol100%100%100%100%
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/governance
   ChainAdmin.sol21.43%14.29%20%25%27, 37–38, 45–46, 55, 55, 55, 57, 59–60, 60, 63, 66, 76, 76, 76–77
   Governance.sol99.07%96.77%100%100%44
contracts/state-transition
   StateTransitionManager.sol72.84%51.52%58.82%85.26%103, 130–132, 136, 189, 232, 239, 257, 263, 270, 282, 289, 296, 304, 311, 319, 326, 339, 341, 407, 426, 429, 444, 449, 474, 73, 78, 84, 84
   TestnetVerifier.sol77.78%66.67%100%75%16, 32
   ValidatorTimelock.sol98.57%100%100%97.67%236
   Verifier.sol89.88%35.71%96.30%90.93%1673–1674, 287–302, 305–308, 311–318, 321–328, 331–332, 335–336, 339, 384–385, 395–396, 406–407, 417–418, 428–429, 444–445, 454, 454–455, 904–905
contracts/state-transition/chain-deps
   DiamondInit.sol88%70%100%100%32–36, 60
   DiamondProxy.sol80.77%62.50%100%88.24%16, 16, 16–17, 27
contracts/state-transition/chain-deps/facets
   Admin.sol81.61%54.35%86.36%92.45%107, 119, 119, 119–121, 147, 147, 147–148, 148, 148, 150, 171, 218–219, 221, 234–235, 241, 260–261, 266, 303, 313, 317, 39, 39, 95
   Executor.sol78.44%72.81%81.25%81.61%107, 167, 171–172, 172, 172–173, 173, 173, 184, 184, 188, 188, 188, 206, 220, 231, 234, 279, 279, 279, 282, 285, 287–288, 294–295, 314–317, 319, 36, 368, 368, 368–371, 373, 376, 379–380, 389, 405, 408–409, 411–413, 424–426, 446, 487, 494, 513, 518, 527–528, 579, 604–605
   Getters.sol81.82%66.67%82.22%83.58%110, 113, 119, 122, 133, 136, 178, 229, 235, 239, 65, 70, 85, 90
   Mailbox.sol85.96%80.56%92.86%85.96%132, 156, 184, 188, 188, 188, 191, 193–194, 196, 201, 203, 206–207, 212–215, 218–219, 311–312, 52
   ZkSyncHyperchainBase.sol82.14%78.57%85.71%85.71%48, 56, 56, 56
contracts/state-transition/data-availability
   CalldataDA.sol100%100%100%100%
   CalldataDAGateway.sol85.71%66.67%100%100%27–28
   RelayedSLDAValidator.sol96.67%83.33%100%100%94
contracts/state-transition/libraries
   Diamond.sol94.81%86.49%100%97.73%110, 112, 114, 116, 119, 184, 294
   LibMap.sol100%100%100%100%
   PriorityQueue.sol100%100%100%100%
   PriorityTree.sol97.62%80%100%100%80
   TransactionValidator.sol97.18%94.12%100%100%54–55
contracts/upgrades
   BaseZkSyncUpgrade.sol69.42%48.65%100%75%102, 102, 102, 104, 107, 110–111, 122, 122, 122, 124, 127, 130–131, 145–147, 165–167, 206, 208, 223, 241–242, 246, 246, 246, 259, 267, 272, 278–279, 283, 291–292,

@StanislavBreadless StanislavBreadless merged commit 336e40c into kl/sync-layer-reorg Aug 20, 2024
23 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-merge-dev-kl-reorg branch August 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

@vladbochok vladbochok Awaiting requested review from vladbochok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.