Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Base Token Address from Chain Registration #700

Merged
merged 10 commits into from
Aug 20, 2024

Conversation

Raid5594
Copy link
Collaborator

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@Raid5594 Raid5594 requested a review from kelemeno August 14, 2024 16:05
@Raid5594 Raid5594 changed the base branch from main to kl/sync-layer-reorg August 14, 2024 16:05
Copy link

github-actions bot commented Aug 14, 2024

Changes to gas cost

Generated at commit: f18d40b8467cf3dd30bd268d0dd5bf25d09c893a, compared to commit: 4c82e7dfc6b903367560a9e7fe0337ba31ca729c

🧾 Summary (100% most significant diffs)

Contract Method Avg (+/-) %
GettersFacetWrapper facetAddresses
facetFunctionSelectors
facets
getFirstUnprocessedPriorityTx
getPriorityQueueSize
getVerifierParams
isFacetFreezable
isValidator
storedBlockHash
util_setAdmin
util_setBaseToken
util_setBaseTokenBridge
util_setBridgehub
util_setFacetAddress
util_setFacetAddresses
util_setFacetFunctionSelectors
util_setFacets
util_setFirstUnprocessedPriorityTx
util_setIsDiamondStorageFrozen
util_setIsFacetFreezable
util_setL2BootloaderBytecodeHash
util_setL2DefaultAccountBytecodeHash
util_setL2SystemContractsUpgradeBatchNumber
util_setL2SystemContractsUpgradeTxHash
util_setPendingAdmin
util_setPriorityQueueSize
util_setStateTransitionManager
util_setTotalBatchesCommitted
util_setTotalBatchesExecuted
util_setTotalBatchesVerified
util_setValidator
util_setVerifier
util_setVerifierParams
-22 ✅
-6 ✅
+86 ❌
-22 ✅
-22 ✅
-22 ✅
-6 ✅
-6 ✅
-22 ✅
+16 ❌
-148 ✅
+61 ❌
-28 ✅
-1 ✅
-12 ✅
-6 ✅
-12 ✅
-22 ✅
-22 ✅
-6 ✅
+22 ❌
+88 ❌
-22 ✅
+89 ❌
-6 ✅
-22 ✅
-28 ✅
-22 ✅
-22 ✅
-22 ✅
-28 ✅
-6 ✅
-22 ✅
-1.66%
-0.32%
+2.14%
-0.75%
-0.45%
-2.59%
-0.29%
-0.95%
-4.03%
+0.04%
-0.34%
+0.14%
-0.06%
-0.00%
-0.01%
-0.01%
-0.01%
-0.05%
-0.05%
-0.01%
+0.05%
+0.20%
-0.05%
+0.20%
-0.01%
-0.03%
-0.06%
-0.05%
-0.05%
-0.05%
-0.08%
-0.01%
-0.02%
UtilsFacet util_getFeeParams
util_getStoredBatchHashes
util_getValidator
util_setBaseTokenGasPriceMultiplierDenominator
util_setBridgehub
util_setFeeParams
util_setIsFrozen
util_setPriorityTxMaxGasLimit
util_setStateTransitionManager
util_setZkPorterAvailability
-22 ✅
-33 ✅
+33 ❌
-22 ✅
-22 ✅
+87 ❌
-22 ✅
-22 ✅
-22 ✅
-22 ✅
-1.16%
-5.18%
+5.52%
-0.10%
-0.40%
+2.11%
-0.21%
-0.42%
-0.41%
-0.18%
DiamondProxy util_getBaseTokenBridge
util_getChainId
util_getFeeParams
util_getL2BootloaderBytecodeHash
util_getL2DefaultAccountBytecodeHash
util_getProtocolVersion
util_getStoredBatchHashes
util_getValidator
util_getZkPorterAvailability
util_setBaseTokenGasPriceMultiplierDenominator
util_setBridgehub
util_setFeeParams
util_setIsFrozen
util_setPriorityTxMaxGasLimit
util_setStateTransitionManager
util_setZkPorterAvailability
+67 ❌
-11 ✅
-22 ✅
+77 ❌
-33 ✅
-11 ✅
-33 ✅
+33 ❌
-11 ✅
-22 ✅
-22 ✅
+87 ❌
-22 ✅
-22 ✅
-22 ✅
-22 ✅
+5.85%
-0.35%
-0.65%
+6.96%
-2.92%
-0.99%
-2.33%
+1.22%
-0.35%
-0.04%
-0.06%
+0.26%
-0.06%
-0.07%
-0.06%
-0.05%
DiamondInit initialize -23,697 ✅ -5.72%
DummyBridgehubSetter acceptAdmin
acceptOwnership
addStateTransitionManager
getHyperchain
initialize
l2TransactionBaseCost
setAddresses
setHyperchain
setPendingAdmin
setSTM
stateTransitionManager
stateTransitionManagerIsRegistered
+22 ❌
+45 ❌
-26 ✅
-32 ✅
+45 ❌
-11 ✅
-66 ✅
-22 ✅
-75 ✅
-22 ✅
-11 ✅
-22 ✅
+0.05%
+0.18%
-0.06%
-4.10%
+0.19%
-0.96%
-0.13%
-0.02%
-0.20%
-0.05%
-0.52%
-1.66%
StateTransitionManager acceptAdmin
createNewChain
initialize
setChainCreationParams
setUpgradeDiamondCut
upgradeCutHash
-22 ✅
+19 ❌
-22 ✅
-22 ✅
-22 ✅
+11 ❌
-0.07%
+0.14%
-0.02%
-0.05%
-0.05%
+2.24%
TransparentUpgradeableProxy acceptAdmin
admin
createNewChain
initialCutHash
l1GenesisUpgrade
protocolVersion
setChainCreationParams
setUpgradeDiamondCut
storedBatchZero
upgradeCutHash
validatorTimelock
-22 ✅
-11 ✅
+355 ❌
+11 ❌
-11 ✅
+11 ❌
-22 ✅
-22 ✅
-11 ✅
+11 ❌
-33 ✅
-0.04%
-1.00%
+0.53%
+0.21%
-1.02%
+0.21%
-0.02%
-0.02%
-1.05%
+0.98%
-0.55%
DiamondCutTestContract diamondCut +21 ❌ +0.01%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
GettersFacetWrapper 1,741,691 (+30,696) facetAddresses
facetFunctionSelectors
facets
getAdmin
getBridgehub
getFirstUnprocessedPriorityTx
getL2SystemContractsUpgradeTxHash
getPriorityQueueSize
getProtocolVersion
getStateTransitionManager
getTotalBlocksExecuted
getVerifier
getVerifierParams
isDiamondStorageFrozen
isFacetFreezable
isValidator
storedBlockHash
util_setAdmin
util_setBaseToken
util_setBaseTokenBridge
util_setBridgehub
util_setFacetAddress
util_setFacetAddresses
util_setFacetFunctionSelectors
util_setFacets
util_setFirstUnprocessedPriorityTx
util_setIsDiamondStorageFrozen
util_setIsFacetFreezable
util_setL2BootloaderBytecodeHash
util_setL2DefaultAccountBytecodeHash
util_setL2SystemContractsUpgradeBatchNumber
util_setL2SystemContractsUpgradeTxHash
util_setPendingAdmin
util_setPriorityQueueSize
util_setStateTransitionManager
util_setTotalBatchesCommitted
util_setTotalBatchesExecuted
util_setTotalBatchesVerified
util_setValidator
util_setVerifier
util_setVerifierParams
1,302 (-22)
1,883 (-6)
4,111 (+86)
397 (-22)
464 (-22)
2,894 (-22)
360 (-22)
4,857 (-22)
359 (-22)
442 (-22)
447 (+87)
398 (-22)
826 (-22)
405 (-22)
1,401 (-6)
628 (-6)
524 (-22)
44,017 (+16)
43,854 (-148)
44,018 (+61)
44,017 (-28)
24,265 (-1)
89,440 (-12)
70,378 (-6)
128,414 (-12)
45,866 (-22)
43,710 (-22)
93,053 (-6)
44,030 (+22)
44,031 (+88)
43,639 (-22)
44,043 (+89)
44,017 (-6)
65,853 (-22)
44,017 (-28)
43,701 (-22)
43,653 (-22)
43,710 (-22)
24,375 (-28)
43,985 (-6)
89,354 (-22)
-1.66%
-0.32%
+2.14%
-5.25%
-4.53%
-0.75%
-5.76%
-0.45%
-5.77%
-4.74%
+24.17%
-5.24%
-2.59%
-5.15%
-0.43%
-0.95%
-4.03%
+0.04%
-0.34%
+0.14%
-0.06%
-0.00%
-0.01%
-0.01%
-0.01%
-0.05%
-0.05%
-0.01%
+0.05%
+0.20%
-0.05%
+0.20%
-0.01%
-0.03%
-0.06%
-0.05%
-0.05%
-0.05%
-0.11%
-0.01%
-0.02%
1,302 (-22)
1,883 (-6)
4,111 (+86)
397 (-22)
464 (-22)
2,894 (-22)
360 (-22)
4,857 (-22)
359 (-22)
442 (-22)
447 (+87)
398 (-22)
826 (-22)
405 (-22)
2,075 (-6)
628 (-6)
524 (-22)
44,017 (+16)
43,854 (-148)
44,018 (+61)
44,017 (-28)
37,691 (-1)
89,440 (-12)
70,378 (-6)
128,414 (-12)
45,866 (-22)
43,710 (-22)
93,053 (-6)
44,030 (+22)
44,031 (+88)
43,639 (-22)
44,043 (+89)
44,017 (-6)
65,853 (-22)
44,017 (-28)
43,701 (-22)
43,653 (-22)
43,710 (-22)
34,331 (-28)
43,985 (-6)
89,354 (-22)
-1.66%
-0.32%
+2.14%
-5.25%
-4.53%
-0.75%
-5.76%
-0.45%
-5.77%
-4.74%
+24.17%
-5.24%
-2.59%
-5.15%
-0.29%
-0.95%
-4.03%
+0.04%
-0.34%
+0.14%
-0.06%
-0.00%
-0.01%
-0.01%
-0.01%
-0.05%
-0.05%
-0.01%
+0.05%
+0.20%
-0.05%
+0.20%
-0.01%
-0.03%
-0.06%
-0.05%
-0.05%
-0.05%
-0.08%
-0.01%
-0.02%
1,302 (-22)
1,883 (-6)
4,111 (+86)
397 (-22)
464 (-22)
2,894 (-22)
360 (-22)
4,857 (-22)
359 (-22)
442 (-22)
447 (+87)
398 (-22)
826 (-22)
405 (-22)
2,075 (-6)
628 (-6)
524 (-22)
44,017 (+16)
43,854 (-148)
44,018 (+61)
44,017 (-28)
44,405 (-1)
89,440 (-12)
70,378 (-6)
128,414 (-12)
45,866 (-22)
43,710 (-22)
93,053 (-6)
44,030 (+22)
44,031 (+88)
43,639 (-22)
44,043 (+89)
44,017 (-6)
65,853 (-22)
44,017 (-28)
43,701 (-22)
43,653 (-22)
43,710 (-22)
34,331 (-28)
43,985 (-6)
89,354 (-22)
-1.66%
-0.32%
+2.14%
-5.25%
-4.53%
-0.75%
-5.76%
-0.45%
-5.77%
-4.74%
+24.17%
-5.24%
-2.59%
-5.15%
-0.29%
-0.95%
-4.03%
+0.04%
-0.34%
+0.14%
-0.06%
-0.00%
-0.01%
-0.01%
-0.01%
-0.05%
-0.05%
-0.01%
+0.05%
+0.20%
-0.05%
+0.20%
-0.01%
-0.03%
-0.06%
-0.05%
-0.05%
-0.05%
-0.08%
-0.01%
-0.02%
1,302 (-22)
1,883 (-6)
4,111 (+86)
397 (-22)
464 (-22)
2,894 (-22)
360 (-22)
4,857 (-22)
359 (-22)
442 (-22)
447 (+87)
398 (-22)
826 (-22)
405 (-22)
2,749 (-6)
628 (-6)
524 (-22)
44,017 (+16)
43,854 (-148)
44,018 (+61)
44,017 (-28)
44,405 (-1)
89,440 (-12)
70,378 (-6)
128,414 (-12)
45,866 (-22)
43,710 (-22)
93,053 (-6)
44,030 (+22)
44,031 (+88)
43,639 (-22)
44,043 (+89)
44,017 (-6)
65,853 (-22)
44,017 (-28)
43,701 (-22)
43,653 (-22)
43,710 (-22)
44,287 (-28)
43,985 (-6)
89,354 (-22)
-1.66%
-0.32%
+2.14%
-5.25%
-4.53%
-0.75%
-5.76%
-0.45%
-5.77%
-4.74%
+24.17%
-5.24%
-2.59%
-5.15%
-0.22%
-0.95%
-4.03%
+0.04%
-0.34%
+0.14%
-0.06%
-0.00%
-0.01%
-0.01%
-0.01%
-0.05%
-0.05%
-0.01%
+0.05%
+0.20%
-0.05%
+0.20%
-0.01%
-0.03%
-0.06%
-0.05%
-0.05%
-0.05%
-0.06%
-0.01%
-0.02%
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
2 (0)
2 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
3 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
1 (0)
2 (0)
1 (0)
1 (0)
1 (0)
1 (0)
2 (0)
2 (0)
2 (0)
2 (0)
1 (0)
1 (0)
UtilsFacet 667,538 (-8,156) util_getBaseTokenBridge
util_getChainId
util_getFeeParams
util_getL2BootloaderBytecodeHash
util_getL2DefaultAccountBytecodeHash
util_getProtocolVersion
util_getStoredBatchHashes
util_getValidator
util_getZkPorterAvailability
util_setBaseTokenGasPriceMultiplierDenominator
util_setBridgehub
util_setFeeParams
util_setIsFrozen
util_setPriorityTxMaxGasLimit
util_setStateTransitionManager
util_setZkPorterAvailability
442 (+67)
346 (-11)
1,212 (-22)
413 (+77)
326 (-33)
324 (-11)
604 (-33)
631 (+33)
392 (-11)
22,508 (-22)
5,440 (-22)
4,201 (+87)
583 (-22)
5,255 (-22)
5,396 (-22)
2,560 (-22)
+17.87%
-3.08%
-1.78%
+22.92%
-9.19%
-3.28%
-5.18%
+5.52%
-2.73%
-0.10%
-0.40%
+2.11%
-3.64%
-0.42%
-0.41%
-0.85%
442 (+67)
346 (-11)
1,878 (-22)
413 (+77)
326 (-33)
324 (-11)
604 (-33)
631 (+33)
392 (-11)
22,508 (-22)
5,440 (-22)
4,201 (+87)
10,533 (-22)
5,255 (-22)
5,396 (-22)
12,510 (-22)
+17.87%
-3.08%
-1.16%
+22.92%
-9.19%
-3.28%
-5.18%
+5.52%
-2.73%
-0.10%
-0.40%
+2.11%
-0.21%
-0.42%
-0.41%
-0.18%
442 (+67)
346 (-11)
1,212 (-22)
413 (+77)
326 (-33)
324 (-11)
604 (-33)
631 (+33)
392 (-11)
22,508 (-22)
5,440 (-22)
4,201 (+87)
10,533 (-22)
5,255 (-22)
5,396 (-22)
12,510 (-22)
+17.87%
-3.08%
-1.78%
+22.92%
-9.19%
-3.28%
-5.18%
+5.52%
-2.73%
-0.10%
-0.40%
+2.11%
-0.21%
-0.42%
-0.41%
-0.18%
442 (+67)
346 (-11)
3,212 (-22)
413 (+77)
326 (-33)
324 (-11)
604 (-33)
631 (+33)
392 (-11)
22,508 (-22)
5,440 (-22)
4,201 (+87)
20,483 (-22)
5,255 (-22)
5,396 (-22)
22,460 (-22)
+17.87%
-3.08%
-0.68%
+22.92%
-9.19%
-3.28%
-5.18%
+5.52%
-2.73%
-0.10%
-0.40%
+2.11%
-0.11%
-0.42%
-0.41%
-0.10%
1 (0)
1 (0)
3 (0)
1 (0)
1 (0)
1 (0)
1 (0)
3 (0)
2 (0)
4 (0)
4 (0)
3 (0)
2 (0)
4 (0)
3 (0)
2 (0)
DiamondProxy 1,913,811 (-77,514) util_getBaseTokenBridge
util_getChainId
util_getFeeParams
util_getL2BootloaderBytecodeHash
util_getL2DefaultAccountBytecodeHash
util_getProtocolVersion
util_getStoredBatchHashes
util_getValidator
util_getZkPorterAvailability
util_setBaseTokenGasPriceMultiplierDenominator
util_setBridgehub
util_setFeeParams
util_setIsFrozen
util_setPriorityTxMaxGasLimit
util_setStateTransitionManager
util_setZkPorterAvailability
1,213 (+67)
3,117 (-11)
2,013 (-22)
1,184 (+77)
1,097 (-33)
1,095 (-11)
1,381 (-33)
1,408 (+33)
3,163 (-11)
50,986 (-22)
34,146 (-22)
33,529 (+87)
29,049 (-22)
33,757 (-22)
34,102 (-22)
31,026 (-22)
+5.85%
-0.35%
-1.08%
+6.96%
-2.92%
-0.99%
-2.33%
+2.40%
-0.35%
-0.04%
-0.06%
+0.26%
-0.08%
-0.07%
-0.06%
-0.07%
1,213 (+67)
3,117 (-11)
3,346 (-22)
1,184 (+77)
1,097 (-33)
1,095 (-11)
1,381 (-33)
2,741 (+33)
3,163 (-11)
50,986 (-22)
34,146 (-22)
33,529 (+87)
39,005 (-22)
33,757 (-22)
34,102 (-22)
40,982 (-22)
+5.85%
-0.35%
-0.65%
+6.96%
-2.92%
-0.99%
-2.33%
+1.22%
-0.35%
-0.04%
-0.06%
+0.26%
-0.06%
-0.07%
-0.06%
-0.05%
1,213 (+67)
3,117 (-11)
2,013 (-22)
1,184 (+77)
1,097 (-33)
1,095 (-11)
1,381 (-33)
3,408 (+33)
3,163 (-11)
50,986 (-22)
34,146 (-22)
33,529 (+87)
39,005 (-22)
33,757 (-22)
34,102 (-22)
40,982 (-22)
+5.85%
-0.35%
-1.08%
+6.96%
-2.92%
-0.99%
-2.33%
+0.98%
-0.35%
-0.04%
-0.06%
+0.26%
-0.06%
-0.07%
-0.06%
-0.05%
1,213 (+67)
3,117 (-11)
6,013 (-22)
1,184 (+77)
1,097 (-33)
1,095 (-11)
1,381 (-33)
3,408 (+33)
3,163 (-11)
50,986 (-22)
34,146 (-22)
33,529 (+87)
48,961 (-22)
33,757 (-22)
34,102 (-22)
50,938 (-22)
+5.85%
-0.35%
-0.36%
+6.96%
-2.92%
-0.99%
-2.33%
+0.98%
-0.35%
-0.04%
-0.06%
+0.26%
-0.04%
-0.07%
-0.06%
-0.04%
1 (0)
1 (0)
3 (0)
1 (0)
1 (0)
1 (0)
1 (0)
3 (0)
2 (0)
4 (0)
4 (0)
3 (0)
2 (0)
4 (0)
3 (0)
2 (0)
DiamondInit 523,294 (-45,202) initialize 22,660 (0) 0.00% 390,593 (-23,697) -5.72% 400,752 (-23,579) -5.56% 420,652 (-26,079) -5.84% 90 (0)
DummyBridgehubSetter 3,978,792 (+35,348) acceptAdmin
acceptOwnership
addStateTransitionManager
admin
getHyperchain
initialize
l2TransactionBaseCost
owner
proveL1ToL2TransactionStatus
proveL2LogInclusion
removeStateTransitionManager
setAddresses
setHyperchain
setPendingAdmin
setSTM
stateTransitionManager
stateTransitionManagerIsRegistered
46,914 (+22)
25,558 (+45)
23,853 (-22)
435 (-11)
749 (-32)
24,233 (+45)
1,140 (-11)
430 (+54)
0 (0)
0 (0)
23,851 (0)
51,043 (-66)
111,384 (-22)
25,965 (-87)
44,187 (-22)
597 (-11)
634 (-22)
+0.05%
+0.18%
-0.09%
-2.47%
-4.10%
+0.19%
-0.96%
+14.36%
+∞%
+∞%
0.00%
-0.13%
-0.02%
-0.33%
-0.05%
-1.81%
-3.35%
46,914 (+22)
25,558 (+45)
41,111 (-26)
1,435 (-11)
749 (-32)
24,233 (+45)
1,140 (-11)
2,319 (+54)
1,389 (-33)
1,533 (+33)
25,502 (+2)
51,043 (-66)
111,421 (-22)
37,912 (-75)
44,224 (-22)
2,097 (-11)
1,300 (-22)
+0.05%
+0.18%
-0.06%
-0.76%
-4.10%
+0.19%
-0.96%
+2.38%
-2.32%
+2.20%
+0.01%
-0.13%
-0.02%
-0.20%
-0.05%
-0.52%
-1.66%
46,914 (+22)
25,558 (+45)
47,544 (-22)
1,435 (-11)
749 (-32)
24,233 (+45)
1,140 (-11)
2,430 (+54)
988 (-8)
1,136 (+25)
25,861 (0)
51,043 (-66)
111,432 (-22)
37,875 (-87)
44,235 (-22)
2,597 (-11)
634 (-22)
+0.05%
+0.18%
-0.05%
-0.76%
-4.10%
+0.19%
-0.96%
+2.27%
-0.80%
+2.25%
0.00%
-0.13%
-0.02%
-0.23%
-0.05%
-0.42%
-3.35%
46,914 (+22)
25,558 (+45)
47,544 (-22)
2,435 (-11)
749 (-32)
24,233 (+45)
1,140 (-11)
2,430 (+54)
3,625 (-36)
3,932 (+37)
26,318 (0)
51,043 (-66)
111,444 (-22)
49,785 (-87)
44,247 (-22)
2,597 (-11)
2,634 (-22)
+0.05%
+0.18%
-0.05%
-0.45%
-4.10%
+0.19%
-0.96%
+2.27%
-0.98%
+0.95%
0.00%
-0.13%
-0.02%
-0.17%
-0.05%
-0.42%
-0.83%
256 (0)
15 (0)
3,584 (0)
1,024 (0)
256 (0)
15 (0)
256 (0)
542 (0)
512 (0)
512 (0)
2,048 (0)
512 (0)
768 (0)
512 (0)
768 (0)
1,024 (0)
3,072 (0)
StateTransitionManager 3,932,278 (-53,469) acceptAdmin
admin
createNewChain
initialCutHash
initialize
l1GenesisUpgrade
protocolVersion
setChainCreationParams
setUpgradeDiamondCut
storedBatchZero
upgradeCutHash
validatorTimelock
30,672 (-22)
457 (-11)
1,205 (+19)
406 (+11)
22,836 (-22)
437 (-11)
340 (+11)
45,213 (-22)
46,685 (-22)
405 (-11)
503 (+11)
436 (-33)
-0.07%
-2.35%
+1.60%
+2.78%
-0.10%
-2.46%
+3.34%
-0.05%
-0.05%
-2.64%
+2.24%
-7.04%
30,672 (-22)
457 (-11)
13,479 (+19)
1,406 (+11)
111,736 (-22)
437 (-11)
1,340 (+11)
45,213 (-22)
46,685 (-22)
405 (-11)
503 (+11)
1,436 (-33)
-0.07%
-2.35%
+0.14%
+0.79%
-0.02%
-2.46%
+0.83%
-0.05%
-0.05%
-2.64%
+2.24%
-2.25%
30,672 (-22)
457 (-11)
13,479 (+19)
1,406 (+11)
22,836 (-22)
437 (-11)
1,340 (+11)
45,213 (-22)
46,685 (-22)
405 (-11)
503 (+11)
1,436 (-33)
-0.07%
-2.35%
+0.14%
+0.79%
-0.10%
-2.46%
+0.83%
-0.05%
-0.05%
-2.64%
+2.24%
-2.25%
30,672 (-22)
457 (-11)
25,754 (+19)
2,406 (+11)
209,526 (-22)
437 (-11)
2,340 (+11)
45,213 (-22)
46,685 (-22)
405 (-11)
503 (+11)
2,436 (-33)
-0.07%
-2.35%
+0.07%
+0.46%
-0.01%
-2.46%
+0.47%
-0.05%
-0.05%
-2.64%
+2.24%
-1.34%
1 (0)
1 (0)
2 (0)
2 (0)
21 (0)
1 (0)
4 (0)
1 (0)
1 (0)
1 (0)
2 (0)
4 (0)
TransparentUpgradeableProxy 845,337 (-22) acceptAdmin
admin
createNewChain
initialCutHash
l1GenesisUpgrade
protocolVersion
setChainCreationParams
setUpgradeDiamondCut
storedBatchZero
upgradeCutHash
validatorTimelock
54,061 (-22)
1,085 (-11)
54,919 (+355)
1,034 (+11)
1,065 (-11)
968 (+11)
97,606 (-22)
98,187 (-22)
1,033 (-11)
1,134 (+11)
1,064 (-33)
-0.04%
-1.00%
+0.65%
+1.08%
-1.02%
+1.15%
-0.02%
-0.02%
-1.05%
+0.98%
-3.01%
54,061 (-22)
1,085 (-11)
67,193 (+355)
5,284 (+11)
1,065 (-11)
5,218 (+11)
97,606 (-22)
98,187 (-22)
1,033 (-11)
1,134 (+11)
5,939 (-33)
-0.04%
-1.00%
+0.53%
+0.21%
-1.02%
+0.21%
-0.02%
-0.02%
-1.05%
+0.98%
-0.55%
54,061 (-22)
1,085 (-11)
67,193 (+355)
5,284 (+11)
1,065 (-11)
5,218 (+11)
97,606 (-22)
98,187 (-22)
1,033 (-11)
1,134 (+11)
6,564 (-33)
-0.04%
-1.00%
+0.53%
+0.21%
-1.02%
+0.21%
-0.02%
-0.02%
-1.05%
+0.98%
-0.50%
54,061 (-22)
1,085 (-11)
79,468 (+355)
9,534 (+11)
1,065 (-11)
9,468 (+11)
97,606 (-22)
98,187 (-22)
1,033 (-11)
1,134 (+11)
9,564 (-33)
-0.04%
-1.00%
+0.45%
+0.12%
-1.02%
+0.12%
-0.02%
-0.02%
-1.05%
+0.98%
-0.34%
1 (0)
1 (0)
2 (0)
2 (0)
1 (0)
4 (0)
1 (0)
1 (0)
1 (0)
2 (0)
4 (0)
DiamondCutTestContract 1,864,745 (+34,605) diamondCut 23,741 (+29) +0.12% 203,605 (+21) +0.01% 45,114 (+23) +0.05% 1,422,528 (+11) +0.00% 20 (0)
L1NativeTokenVault 1,937,741 (+12)
DummyBridgehub 172,435 (+24)
DummySharedBridge 870,082 (-12)
DummyStateTransitionManager 3,952,533 (-45,286)
GettersFacet 921,674 (+34,387)
MailboxFacet 3,008,460 (+12)
GenerateForceDeploymentsData 1,249,909 (-12)
Utils 4,681,703 (-45,468)

Base automatically changed from kl/sync-layer-reorg to sync-layer-stable August 19, 2024 12:39
@StanislavBreadless StanislavBreadless changed the base branch from sync-layer-stable to kl/sync-layer-reorg August 19, 2024 14:21
Copy link

Coverage after merging ra/deprecate-baseToken-mapping into kl/sync-layer-reorg will be

88.71%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
../da-contracts/contracts
   RollupL1DAValidator.sol67.11%50%83.33%73.91%134, 137, 137, 137, 139, 170, 172, 25, 25, 25–26, 26, 26, 28, 30–31, 35–36, 59, 61, 61, 61–62, 64
contracts/bridge
   BridgeHelper.sol100%100%100%100%
   L1AssetRouter.sol95.19%89.29%94.87%97.88%137, 152, 209, 229, 274, 327, 379, 514, 531, 552, 735–736, 871
   L1ERC20Bridge.sol100%100%100%100%
   L1NativeTokenVault.sol96.12%97.62%84.62%97.30%251, 256, 44
contracts/bridgehub
   Bridgehub.sol71.48%44.16%78.95%84.40%104, 109, 115, 120, 120, 159, 187, 187–188, 190–191, 191, 191–192, 198–199, 199, 199–200, 200, 200, 202–203, 203, 203–204, 295–297, 299–301, 303, 329, 338, 343–344, 394–395, 397, 397, 397, 440, 448–449, 452, 452, 452–453, 475, 513, 537–538, 617, 620–621, 625–626, 653–654, 659–660, 688, 693, 99
   MessageRoot.sol91.38%61.54%100%100%156, 162, 69, 76, 94
   STMDeploymentTracker.sol79.49%50%90%94.12%110, 114, 31, 38, 61, 88, 91
contracts/common
   ReentrancyGuard.sol100%100%100%100%
contracts/common/libraries
   DataEncoding.sol80%100%100%66.67%72, 80
   DynamicIncrementalMerkle.sol74.42%100%80%72.22%67–70, 72–74, 76–78
   FullMerkle.sol100%100%100%100%
   L2ContractHelper.sol55.88%30%60%68.42%29, 32–33, 46–47, 47, 47, 49, 49, 49, 56, 86, 90
   Merkle.sol73.85%68.18%75%76.92%52–53, 53, 53–54, 54, 54–55, 55, 55, 57–59, 62, 65, 83
   MessageHashing.sol100%100%100%100%
   SemVer.sol100%100%100%100%
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/governance
   ChainAdmin.sol22.22%20%33.33%20%16, 28–29, 38, 38, 38, 40, 42–43, 43, 46, 49
   Governance.sol99.07%96.77%100%100%44
contracts/state-transition
   StateTransitionManager.sol72.84%51.52%58.82%85.26%103, 130–132, 136, 189, 232, 239, 257, 263, 270, 282, 289, 296, 304, 311, 319, 326, 339, 341, 407, 421, 424, 439, 444, 469, 73, 78, 84, 84
   TestnetVerifier.sol77.78%66.67%100%75%16, 32
   ValidatorTimelock.sol98.57%100%100%97.67%236
   Verifier.sol89.88%35.71%96.30%90.93%1673–1674, 287–302, 305–308, 311–318, 321–328, 331–332, 335–336, 339, 384–385, 395–396, 406–407, 417–418, 428–429, 444–445, 454, 454–455, 904–905
contracts/state-transition/chain-deps
   DiamondInit.sol88%70%100%100%32–36, 60
   DiamondProxy.sol80.77%62.50%100%88.24%16, 16, 16–17, 27
contracts/state-transition/chain-deps/facets
   Admin.sol81.61%54.35%86.36%92.45%107, 119, 119, 119–121, 147, 147, 147–148, 148, 148, 150, 171, 217–218, 220, 233–234, 240, 259–260, 265, 302, 312, 316, 39, 39, 95
   Executor.sol78.44%72.81%81.25%81.61%107, 167, 171–172, 172, 172–173, 173, 173, 184, 184, 188, 188, 188, 206, 220, 231, 234, 279, 279, 279, 282, 285, 287–288, 294–295, 314–317, 319, 36, 368, 368, 368–371, 373, 376, 379–380, 389, 405, 408–409, 411–413, 424–426, 446, 487, 494, 513, 518, 527–528, 579, 604–605
   Getters.sol81.82%66.67%82.22%83.58%110, 113, 119, 122, 133, 136, 178, 229, 235, 239, 65, 70, 85, 90
   Mailbox.sol57.87%47.22%57.14%61.40%107, 115, 131–132, 132, 132, 134–135, 143–145, 156, 167–168, 170–171, 173, 178, 182, 182–184, 184, 184–185, 188, 188, 188, 191, 193–194, 196, 201, 203, 206–207, 212–215, 218–219, 236, 242, 242, 242, 250, 255, 282, 311–312, 389, 400, 406, 52, 52, 545, 545, 545–546, 566, 75, 85
   ZkSyncHyperchainBase.sol82.14%78.57%85.71%85.71%48, 56, 56, 56
contracts/state-transition/data-availability
   CalldataDA.sol100%100%100%100%
   CalldataDAGateway.sol85.71%66.67%100%100%27–28
   RelayedSLDAValidator.sol96.67%83.33%100%100%94
contracts/state-transition/libraries
   Diamond.sol94.81%86.49%100%97.73%110, 112, 114, 116, 119, 184, 294
   LibMap.sol100%100%100%100%
   

@Raid5594 Raid5594 merged commit 3de3430 into kl/sync-layer-reorg Aug 20, 2024
23 checks passed
@Raid5594 Raid5594 deleted the ra/deprecate-baseToken-mapping branch August 20, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants