Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: synchronise linting rules of repositories #65

Closed

Conversation

benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Oct 23, 2023

What ❔

Synchronise the linting and formatting rules of the repositories, use the configs from the era-system-contracts repository as a base.

Steps:

  1. update the linf/format configs of the ethereum dir
  2. add the lint/format configs to the zksync dir
  3. add missing packages, update outdated packages to the the same version as in the era-system-contracts
  4. format/lint all of the files in both dirs
  5. add zksync linting to the CI

Why ❔

Currently the era-contracts and the era-system-contracts repositories have different linting and formatting rules, the goal of this task is to synchronise them.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via yarn prettier:write and yarn lint:fix.

@benceharomi benceharomi changed the base branch from main to dev October 23, 2023 13:51
@benceharomi benceharomi marked this pull request as ready for review October 23, 2023 13:58
@benceharomi benceharomi marked this pull request as draft October 23, 2023 13:59
@benceharomi benceharomi changed the base branch from dev to main October 23, 2023 14:00
@benceharomi benceharomi changed the base branch from main to dev October 23, 2023 14:00
benceharomi pushed a commit that referenced this pull request Nov 17, 2023
koloz193 pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant