Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boojum): Add a flag to control which prover to use at diamond init #63

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Oct 4, 2023

What ❔

  • depending on the CONTRACTS_PROVER_AT_GENESIS environment variable, set correct VkHashes

Why ❔

  • later migrations of provers, happen via migration mechanism, but for boojnet and local setups, we need a way to set the prover that will be used at genesis.
  • otherwise, we'd have to run the 'old' prover to prove at least one block (to do the migration).

Comments

Change is backwards compatible - if flag is not set, we'll use the old (current) setup

@mm-zk mm-zk merged commit 7576400 into dev Oct 5, 2023
@mm-zk mm-zk deleted the mmzk_1004_select_prover branch October 5, 2023 08:05
StanislavBreadless added a commit that referenced this pull request Dec 22, 2023
Fix incorrect calculation for required number of keccak256 hash rounds
koloz193 pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants