Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with public key & added tests #61

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Fixed issue with public key & added tests #61

merged 7 commits into from
Oct 4, 2023

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Oct 4, 2023

What ❔

  • We were masking wrong bits when generating the public key for the new proof system
  • Also added more tests to verify hashes computations.

Why ❔

  • steps to make boojnet work

@mm-zk mm-zk requested a review from ly0va October 4, 2023 06:35
ly0va
ly0va reviewed Oct 4, 2023
View reviewed changes
ethereum/contracts/zksync/Verifier.sol Outdated
mstore(VK_GATE_SETUP_3_Y_SLOT, 0x215fa609a1a425b84c9dc218c6cf999596d9eba6d35597ad7aaf2d077a6616ed)
mstore(VK_GATE_SETUP_4_X_SLOT, 0x1a26e6deccf91174ab13613363eb4939680828f0c6031f5039f9e6f264afa68c)
mstore(VK_GATE_SETUP_4_Y_SLOT, 0x1f5b2d6bffac1839edfd02cd0e41acc411f0ecbf6c5c4b1da0e12b68b99cb25d)
mstore(VK_GATE_SETUP_0_X_SLOT, 0x054b0ed7dd15637829a8311ff09e912292bb5009fa5293632b7f590f63fbb8e4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this key the same as in #60 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the commits are the same, should we close the #60 then?

vladbochok
vladbochok reviewed Oct 4, 2023
View reviewed changes
ethereum/contracts/dev-contracts/test/ExecutorProvingTest.sol Outdated
s.zkPorterIsAvailable = false;
}

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: new line :)

@ly0va ly0va merged commit 0bd80df into boojum-integration Oct 4, 2023
11 checks passed
@ly0va ly0va deleted the mmzk_1003_v2_tests branch October 4, 2023 12:45
StanislavBreadless added a commit that referenced this pull request Dec 22, 2023
@StanislavBreadless
Merge pull request #61 from matter-labs/vb-fix-oz-keccak256-audit-n-02
d2001f6 
Add comments for keccak256 wrapper
koloz193 pushed a commit that referenced this pull request Dec 11, 2024
@StanislavBreadless
Restore loadtest final merge (#61)
7d809dd 
Clone of matter-labs/era-contracts-private#10,
but targeted towards the gateway release candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly0va ly0va ly0va left review comments

@vladbochok vladbochok vladbochok left review comments

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mm-zk @vladbochok @ly0va