Shift public input by 4 bytes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbochok
reviewed
Oct 2, 2023
| @@ -62,7 +62,7 @@ uint256 constant COMMIT_TIMESTAMP_APPROXIMATION_DELTA = $$( | |||
| ); | |||
|
|
|||
| /// @dev Bit mask to apply for verifier public input before verifying. | |||
| uint256 constant INPUT_MASK = $$(~uint256(0) >> 8); | |||
| uint256 constant INPUT_MASK = $$(~uint256(0) >> 32); | |||
There was a problem hiding this comment.
That’s how public input is constructed/reconstructed in new Boojum and it’s wrapper
|
I’ll tentatively approve, let’s wait for proof generation anyway |
shamatar
approved these changes
Oct 2, 2023
vladbochok
approved these changes
Oct 2, 2023
StanislavBreadless
added a commit
that referenced
this pull request
Dec 22, 2023
Add constructor code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Shift public input by 4 bytes
Why ❔
Needed for correct public input generation here
Checklist
zk fmtandzk lint.